cli: More environment detection #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has `bootc upgrade` inside a container image give a more useful error message. At least one user reran the container as root to try it... Signed-off-by: Colin Walters <walters@verbum.org>
Just on general principle. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
switch-earlier-error
branch
from
91db5ea to
5bf05e5
Compare
Before we even check for root, verify that we are on an ostree-booted host. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
switch-earlier-error
branch
from
5bf05e5 to
e20ab16
Compare
ckyrouac
approved these changes
May 29, 2024
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
Release 0.2.13
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
Release 0.12.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli: Check for container before root
This has
bootc upgradeinside a container image give a more usefulerror message.
At least one user reran the container as root to try it...
cli: Check for non-ostree container too
Just on general principle.
Signed-off-by: Colin Walters walters@verbum.org
cli: Detect non-ostree and error out earlier
Before we even check for root, verify that we are on an ostree-booted
host.
Signed-off-by: Colin Walters walters@verbum.org
Closes: #554