Skip to content

Conversation

cgwalters
Copy link
Collaborator

Previous work started moving our tests into an external binary; this is just cleaner because it can test things how a user would test. Also, we started using libtest-mimic to have a "real" test scaffolding that e.g. allows selecting individual tests to run, etc.

Complete the picture here by moving the remaining bits into the tests-integration binary. We now run the tests-integration binary in two ways in e.g. Github Actions:

  • It's compiled directly on the Ubuntu runner, and orchestrates things itself
  • It's built in our default container image (Fedora) but as an external /usr/bin/bootc-integration-tests binary

Also while we're here, drop the kola tests.

@cgwalters cgwalters force-pushed the testing branch 3 times, most recently from a9775a5 to b5eee54 Compare May 31, 2024 21:09
Previous work started moving our tests into an external binary;
this is just cleaner because it can test things how a user
would test.  Also, we started using `libtest-mimic` to
have a "real" test scaffolding that e.g. allows selecting
individual tests to run, etc.

Complete the picture here by moving the remaining bits into
the tests-integration binary.  We now run the `tests-integration`
binary in two ways in e.g. Github Actions:

- It's compiled directly on the Ubuntu runner, and orchestrates
  things itself
- It's built in our default container image (Fedora) but as an external
  `/usr/bin/bootc-integration-tests` binary

Also while we're here, drop the kola tests.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of changes here but seems ok to me.

@cgwalters cgwalters merged commit 70edd01 into bootc-dev:main Jun 4, 2024
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 6, 2024
lib: Make image configuration always present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants