TMT test tweaks #791
Merged
TMT test tweaks #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is temporary while waiting for tmt to release the bootc provision plugin. Signed-off-by: Chris Kyrouac <ckyrouac@redhat.com>
1 -> enabled. This adds -vvvvv to the tmt run invocation when using `make test-tmt` to stream detailed test run output. Signed-off-by: Chris Kyrouac <ckyrouac@redhat.com>
This is required for the bootc install tests that use a custom image. Otherwise, the cached image will be used instead of the image built from the bootc provision plugin. Signed-off-by: Chris Kyrouac <ckyrouac@redhat.com>
|
added another commit to delete the cached testcloud image before each tmt run invocation. |
cgwalters
approved these changes
Sep 18, 2024
Comment on lines
+193
to
+197
| let verbose = if verbose_enabled == 1 { | ||
| Some("-vvvvv".to_string()) | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
let verbose = (verbose_enabled == 1).then_some("-vvvvv"); is a bit shorter, also avoids the unnecessary to_string() allocation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmt: Add TMT_PLUGINS env to tmt run invocation
This is temporary while waiting for tmt to release the bootc provision
plugin.
tmt: Add TMT_VERBOSE env var
1 -> enabled. This adds -vvvvv to the tmt run invocation when using
make test-tmtto stream detailed test run output.