Bump ostree-ext to 0.15.1 and use proper digests where possible #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/me hopes to not break everything this time |
cgwalters
reviewed
Sep 24, 2024
lib/src/cli.rs
Outdated
| tracing::debug!("fetched: {fetched_digest}"); | ||
| let staged_unchanged = staged_digest | ||
| .map(|d| d == fetched_digest) | ||
| .map(|d| d == *fetched_digest) |
There was a problem hiding this comment.
Minor style nit I think coercing to a reference like &d == fetched_digest is perhaps more idomatic?
There was a problem hiding this comment.
Yeah I suppose so. That's more my historic C-like brain wanting to dereference two pointers to compare the values instead of comparing the actual pointers. But rust already does the dereference for you (I had to go look up how that actually works!).
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb
force-pushed
the
ostree-rs-bump
branch
from
58e1524 to
ad7af3f
Compare
cgwalters
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Eckersberg jeckersb@redhat.com