Skip to content

Conversation

cgwalters
Copy link
Collaborator

These files help clarify/formalize some information. In particular I'd like to look at tools that auto-sync from MAINTAINERS to the github permissions so that we can maintain that in a git-ops fashion.

Copy link
Contributor

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly the nittiest review I've ever given. Looks good to me on the whole, just some small grammatical stuff that doesn't affect the message of the PR in any way.

If my suggestions are too nitty/unnecessary please let me know and I will approve this


**End-user**: The organization runs bootc in production in some way.

**Integration**: The organization has a product that integrates with bootc, but does not contain bootc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nits: Would integrator make more grammatical sense than integration here? In the context of using end-user and vendor as the other options

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm could be but I was basing this on e.g. https://github.com/kubevirt/kubevirt/blob/main/ADOPTERS.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, I thought it was odd how the verbiage switches up. I will approve momentarily

These files help clarify/formalize some information.
In particular I'd like to look at tools that auto-sync from MAINTAINERS
to the github permissions so that we can maintain that in a git-ops
fashion.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Contributor

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters cgwalters merged commit cc6ddc3 into bootc-dev:main Oct 23, 2024
24 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants