add combined http and cli lesson type #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovranek
commented
Jan 2, 2025
skovranek
commented
Jan 2, 2025
skovranek
commented
Jan 2, 2025
skovranek
commented
Jan 2, 2025
wagslane
approved these changes
Jan 2, 2025
skovranek
force-pushed
the
ms_combine_lesson_types
branch
2 times, most recently
from
89d32a6 to
f377cad
Compare
skovranek
force-pushed
the
ms_combine_lesson_types
branch
from
f377cad to
f229685
Compare
skovranek
force-pushed
the
ms_combine_lesson_types
branch
from
f229685 to
fdd50a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lesson type to combine http and cli types. Commands can use response variables from request steps.
Also handles positional parameters for cli commands ($1, $2, etc). If the lesson expects it, should it reject a bootdev run that misses them?