Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References of struct inode are not found #44

Closed
flipreverse opened this issue Oct 4, 2018 · 4 comments
Closed

References of struct inode are not found #44

flipreverse opened this issue Oct 4, 2018 · 4 comments

Comments

@flipreverse
Copy link

Hi!

I was looking for all references of a certain struct in the Linux Kernel when I found out that
exlixir does not list all of them.
If I search for super_block, for example, I do get a list of references:
https://elixir.bootlin.com/linux/v4.19-rc6/ident/super_block
It works as expected for typedefs as well:
https://elixir.bootlin.com/linux/v4.19-rc6/ident/journal_t

However, if I search for inode, I just get the definition of struct inode:
https://elixir.bootlin.com/linux/v4.19-rc6/ident/inode

I suppose this is a bug in the update mechanism.

Regards,
Alex

@flipreverse
Copy link
Author

I have the answer to that question: 'inode' is a blacklisted keyword in lib.py.
Why is inode blacklisted?

michaelopdenacker pushed a commit that referenced this issue Jul 16, 2019
This caused important symbols to be ignored (at least for the
list of instances) See #44

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
@michaelopdenacker
Copy link

Hi Alex,
Many thanks for the bug report.
I wasn't the one developing this part. I remember that symbols had to be blacklisted, typically generic variable names that are found everywhere, and which have nothing in common between two files.
Our developer may have considered that "inode" was found in too many places.
However, I believe that inode is an important kernel structure that must be indexed properly, so I added it back, together with a few other ones.
See 5d35c4d
I'm generating a new database. It should be deployed in one or two days.
I'll let you know when this is done.
Thanks again,
Cheers,
Michael.

@flipreverse
Copy link
Author

Hi Alex,
Many thanks for the bug report.
No problem. :)
I wasn't the one developing this part. I remember that symbols had to be blacklisted, typically generic variable names that are found everywhere, and which have nothing in common between two files.
Our developer may have considered that "inode" was found in too many places.
However, I believe that inode is an important kernel structure that must be indexed properly, so I added it back, together with a few other ones.
See 5d35c4d
I'm generating a new database. It should be deployed in one or two days.
I'll let you know when this is done.
Thanks again,
Cheers,
Michael.
Thanks!

@michaelopdenacker
Copy link

Fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants