Convert to TypeScript. #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@izaakschroeder What's the motivation for switching to typescript? |
|
@10xjs seems to be the general current consensus in the community. I've tried it out on a few things now and there are definitely things I like – generally better editor support, much less resource intensive, updates don't seem to blow up the types constantly, more packages seem to be built with it now ( I also like the fact it's possible to generate typings including ones for flow, whereas with flow you had to strictly use the source code. |
10xjs
reviewed
Feb 27, 2019
10xjs
reviewed
Feb 27, 2019
10xjs
reviewed
Feb 27, 2019
10xjs
reviewed
Feb 27, 2019
10xjs
reviewed
Feb 27, 2019
izaakschroeder
force-pushed
the
typescript
branch
6 times, most recently
from
99226ac to
18ed70d
Compare
izaakschroeder
force-pushed
the
typescript
branch
from
7775194 to
821c038
Compare
10xjs
force-pushed
the
typescript
branch
2 times, most recently
from
463de22 to
3db7e0c
Compare
izaakschroeder
force-pushed
the
typescript
branch
from
3db7e0c to
6d298ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. It compiles, it lints, it generates the correct bundle.
TODO:
jesthappy.There's actually one typebug TS picked up but flow didn't. 🤷♂️
Kind of waiting on the queue of renovate PRs right now.