Eliminate Warnings from net-http
#650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donv
reviewed
Jul 20, 2022
|
|
||
| test "bootstrap_form_for helper works for serialized hash attributes" do | ||
| @user.preferences = { favorite_color: "cerulean" } | ||
| @user.preferences = { "favorite_color" => "cerulean" } |
There was a problem hiding this comment.
Why change key from symbol to string?
There was a problem hiding this comment.
Ah, I see the separate PR for this. 👍
donv
approved these changes
Jul 20, 2022
|
Maybe rebase this PR? |
lcreid
force-pushed
the
eliminate-warnings-errors
branch
from
3b021c2 to
9298bfb
Compare
lcreid
force-pushed
the
eliminate-warnings-errors
branch
from
989c745 to
989ae59
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test suite was generating a lot of annoying warning messages. Apparently, requiring
net-httpexplicitly is the way to get rid of them.For more background, see this issue: ruby/net-imap#16.
After a lot of flailing around, and a good PR from @donv , this seems to be mostly unnecessary. I just added one tweak to the contributing documentation, and a tweak to the
docker-compose.yml.