feat(navbar-nav): New b-navbar-nav component #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class 'nav' is no longer used in BS V4.beta.2 when the nav is a navbar-nav.
Codecov Report
@@ Coverage Diff @@
## dev #1231 +/- ##
=========================================
- Coverage 33.02% 33% -0.02%
=========================================
Files 109 110 +1
Lines 2877 2881 +4
Branches 895 925 +30
=========================================
+ Hits 950 951 +1
- Misses 1548 1550 +2
- Partials 379 380 +1
Continue to review full report at Codecov.
|
Dedicated `b-navbar-nav` functional component, with less weight than the `b-nav`
tmorehouse
changed the title
tmorehouse
commented
Oct 24, 2017
docs/components/navbar/meta.json
Outdated
| @@ -3,11 +3,11 @@ | |||
| "component": "bNavbar", | |||
| "components": [ | |||
| "bNavbarNav", | |||
| "bNavbarBrand" | |||
| "bNavbarBrand", | |||
mosinve
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class 'nav' is no longer used in BS V4.beta.2 when the nav is a navbar-nav.
Introduce a new lightweight functional
<b-navbar-nav>component.Deprecate
is-nav-barprop on<b-nav>