Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-pagination menu keyboard navigation Jaws Support #4322

Closed
fabo15x opened this issue Oct 30, 2019 · 7 comments · Fixed by #4325, mariazevedo88/hash-generator-js#17 or CloudsdaleGroup/AnimFM#3
Closed
Assignees
Projects

Comments

@fabo15x
Copy link

@fabo15x fabo15x commented Oct 30, 2019

When using Jaws Screen reader, the menu keyboard navigation is announced as "to move through items press the UP or DOWN arrow" but the supported keys for such navigation in the component are LEFT and RIGHT instead.
The b-pagination component should support UP and DOWN arrow keys.

@fabo15x fabo15x changed the title b-pagination menu keyboard navigation b-pagination menu keyboard navigation Jaws Support Oct 30, 2019
@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Oct 30, 2019

This might be an issue with JAWS, as the list should be interpreted as aria-orientation="horizontal", but maybe we need to explicitly add the aria-orientation attribute.

@tmorehouse tmorehouse self-assigned this Oct 30, 2019
@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Oct 30, 2019

Although after a bit of digging, it looks like JAWS may not support/respect the aria-orientation attribute, and assumes that because the root element is a <ul> (a list) it is vertical in orientation even though pagination has role="menubar" which implies horizontal orientation (whereas role="menu" implies vertical orientation)

So we may have to add in both left/right and up/down navigation support

@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Oct 30, 2019

@fabo15x Which version of JAWS are you using?

@fabo15x

This comment has been minimized.

Copy link
Author

@fabo15x fabo15x commented Oct 30, 2019

@fabo15x Which version of JAWS are you using?

JAWS 2019.1907.42

tmorehouse added a commit that referenced this issue Oct 30, 2019
… support (closes #4322)
@tmorehouse tmorehouse added this to To do in 2.1.0 via automation Oct 30, 2019
@tmorehouse tmorehouse moved this from To do to In progress in 2.1.0 Oct 30, 2019
@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Oct 30, 2019

@fabo15x PR #4322 adds in support for UP/DOWN arrow keys (in addition to the existing LEFT/RIGHT arrow keys) and will be available in release v2.1.0

@fabo15x

This comment has been minimized.

Copy link
Author

@fabo15x fabo15x commented Oct 30, 2019

@fabo15x PR #4322 adds in support for UP/DOWN arrow keys (in addition to the existing LEFT/RIGHT arrow keys) and will be available in release v2.1.0

What a quick turnaround. Thank you so much!

2.1.0 automation moved this from In progress to Done Oct 30, 2019
tmorehouse added a commit that referenced this issue Oct 30, 2019
…support for JAWS (fixes #4322) (#4325)
@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Nov 13, 2019

BootstrapVue v2.1.0 has been released, which has a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.1.0
  
Done
3 participants
You can’t perform that action at this time.