Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] "Edit this page" link broken #639

Closed
jimt opened this issue Jul 5, 2017 · 3 comments
Closed

[docs] "Edit this page" link broken #639

jimt opened this issue Jul 5, 2017 · 3 comments
Assignees
@tmorehouse @pi0
Labels
Type: Bug Type: Docs

Comments

@jimt
Copy link
Contributor

jimt commented Jul 5, 2017

The Edit this page link is broken on https://bootstrap-vue.js.org/docs/setup/
@alexsasharegan
Copy link
Member

Looks like a concatenated path gone south. Chances are the trailing slash varies based on how you get to a page. Maybe we can normalize the path with a trim slashes. Just gotta find where the logic for this is.

@tmorehouse
Copy link
Member

tmorehouse commented Jul 5, 2017 •
edited
Loading

This is an oddball case. The edit this page link is based on the URL path, and then prepends the github URL. For SETUP.md, there is no /docs/setup/README.md (at GitHub), but rather a file called /docs/SETUP.md

Maybe the bit of code that generates the edit this page button/link needs to do a v-if to test if it is /docs/setup, and if so link to just /docs/SETUP.md

tmorehouse added a commit that referenced this issue Jul 5, 2017
@tmorehouse
fix(docs.vue): Fix link to edit setup
0613868 
Fixes  #639

"Edit this page" link broken for /docs/setup
@tmorehouse tmorehouse mentioned this issue Jul 5, 2017
Merged
@tmorehouse
Copy link
Member

PR #641 should fix this.

@tmorehouse tmorehouse self-assigned this Jul 5, 2017
@pi0 pi0 closed this as completed in #641 Jul 5, 2017
pi0 pushed a commit that referenced this issue Jul 5, 2017
@tmorehouse @pi0
fix(docs.vue): Fix link to edit setup doc (#641)
836db33 
* fix(docs.vue): Fix link to edit setup

Fixes  #639

"Edit this page" link broken for /docs/setup

* fix(docs.vue): Handle edit this page for paths ending in /

* fix(docs.vue): Special case for /docs/contributing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmorehouse tmorehouse

@pi0 pi0

Labels
Type: Bug Type: Docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jimt @tmorehouse @pi0 @alexsasharegan