New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): Add Bootstrap V4 anticipated verticaly centered modal #1246

Merged
merged 3 commits into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Oct 26, 2017

Vertically centered modals will be coming in Bootstrap V4

twbs/bootstrap#24510

This adds a new prop centered which renders the modal centered vertically.

Note vertically centered modals are not suited for tall content modals, as there is a potential for the header (or top part of the modal) to become inaccessible. They are better suited to one or two line content (i.e. confirmation dialogs).

The custom CSS in modal.vue can be removed once V4.beta.3 (or later) arrives

feat(modal): Add Bootstrap V4 anticipated verticaly centered modal
Vertically centered modals will be coming in Bootstrap V4.beta.3

This adds a new prop `centered` which renders the modal centered vertically.

twbs/bootstrap#24510

Note vertically centered modals are **not** suited for tall content modals, as there is a potential for the header (or top part of the modal) to become inaccessible).  They are better suited to one or two line content (i.e. confirmation dialogs).

The custom CSS in modal.vue can be removed once V4.beta.3 (or later) arrives
@codecov-io

This comment has been minimized.

codecov-io commented Oct 26, 2017

Codecov Report

Merging #1246 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1246   +/-   ##
=======================================
  Coverage   32.99%   32.99%           
=======================================
  Files         110      110           
  Lines        2882     2882           
  Branches      926      926           
=======================================
  Hits          951      951           
  Misses       1551     1551           
  Partials      380      380
Impacted Files Coverage Δ
lib/components/modal.vue 1.12% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a9aa5...813e390. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Oct 26, 2017

SpellCheck
📜
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Oct 26, 2017

Ive also made a proposal to twbs/BSV4 on handling viewport overflowing vertically centered modals. So maybe once V4.beta.3 rolls around, we can remove the warning in the docs.

@mosinve

This comment has been minimized.

Member

mosinve commented Oct 26, 2017

Cool.. So we are a step ahead official BS4? )))

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Oct 26, 2017

Yep, 1/2 step ahead 🙂

@tmorehouse tmorehouse merged commit 4a8ce2c into dev Oct 26, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the modal/centered branch Oct 26, 2017

@tmorehouse tmorehouse referenced this pull request Oct 27, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment