New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v-b-modal directive unbinding #1617

Merged
merged 7 commits into from Feb 15, 2018

Conversation

Projects
None yet
2 participants
@dmocho
Contributor

dmocho commented Feb 15, 2018

This pull request fixes #1613 keeping the default behavior of utils/target untouched.
Multiple event listeners for event type are possible and they are unbound all together.

dmocho added some commits Feb 15, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 15, 2018

Codecov Report

Merging #1617 into dev will increase coverage by 0.18%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1617      +/-   ##
==========================================
+ Coverage   60.14%   60.32%   +0.18%     
==========================================
  Files         153      153              
  Lines        2850     2866      +16     
  Branches      782      788       +6     
==========================================
+ Hits         1714     1729      +15     
- Misses        817      818       +1     
  Partials      319      319
Impacted Files Coverage Δ
src/utils/target.js 100% <100%> (ø) ⬆️
src/directives/modal/modal.js 55.55% <75%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4464f0a...49f029b. Read the comment docs.

mosinve and others added some commits Feb 15, 2018

Update target.js
library build process doesn't like Object.spread ;(

@mosinve mosinve merged commit 3f6a86a into bootstrap-vue:dev Feb 15, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 94.11% of diff hit (target 60.14%)
Details
codecov/project 60.32% (+0.18%) compared to 4464f0a
Details
deploy/netlify Deploy preview ready!
Details

@dmocho dmocho deleted the dmocho:patch-1 branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment