Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jan 2, 2019

Description of Pull Request:

Create local customizable version of markdown-loader (as marked-loader)

Gets around compatibility issues between markdown-loader 4.0.0 and marked 0.6.0

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #2380 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2380   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files         167      167           
  Lines        3221     3221           
  Branches      894      894           
=======================================
  Hits         2175     2175           
  Misses        767      767           
  Partials      279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff25314...161975a. Read the comment docs.

@tmorehouse tmorehouse changed the title docs: create local marked-loader.js fix(docs): create local marked-loader.js Jan 3, 2019
@tmorehouse tmorehouse merged commit 06cfb47 into dev Jan 3, 2019
@tmorehouse tmorehouse deleted the tmorehouse/markdown branch January 3, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant