-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(security): strip html tags #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2479 +/- ##
==========================================
+ Coverage 71.55% 71.57% +0.02%
==========================================
Files 170 170
Lines 3227 3230 +3
Branches 913 914 +1
==========================================
+ Hits 2309 2312 +3
Misses 666 666
Partials 252 252
Continue to review full report at Codecov.
|
@pi0 Tooltips and popovers are broken |
in Pagination, buttons default values (HTML entites) are showing as text: |
@lianee fixed on dev |
Description of Pull Request:
Clarification letter: https://gist.github.com/pi0/674d49d5f1c2ccfe20d3b1e29ae7b497
Fixes #1974. Related to #2477.
PR checklist:
textContent
and avoitinnerHTML
stripTags
in needed placesDoes this PR introduce a breaking change? (check one)
If yes, please describe the impact:
Prevent's using HTML in mentioned areas. Users should alternatively use slots.
Components
*
new props / slotsEssential:
Others:
Mixins
Essential:
Others: