Remove bundled 3rd party sw (1.4-maint)

[ThomasWaldmann]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (4abc7f1) to head (30dc27b).
Report is 130 commits behind head on 1.4-maint.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@              Coverage Diff              @@
##           1.4-maint    #8117      +/-   ##
=============================================
- Coverage      82.63%   82.62%   -0.01%     
=============================================
  Files             38       38              
  Lines          10966    10966              
  Branches        2098     2098              
=============================================
- Hits            9062     9061       -1     
- Misses          1343     1344       +1     
  Partials         561      561              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kubedzero]

I thankfully just came across this when trying to build Borg by way of Pip. I tried running pip3 install "borgbackup[pyfuse3]" without any of the lz4, libstd, or xxhash libraries installed on my system and got the following error during build:

        File "/tmp/pip-build-env-eyg010z7/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 318, in run_setup
          exec(code, locals())
        File "<string>", line 145, in <module>
        File "<string>", line 125, in lib_ext_kwargs
      Exception: Could not find lz4 lib/headers, please set BORG_LIBLZ4_PREFIX or ensure liblz4.pc is in PKG_CONFIG_PATH.

I fixed the issue and was able to build Borg 1.4.0 successfully after installing the libraries on my system, lz4-1.10.0-x86_64-1.txz and zstd-1.5.6-x86_64-1.txz and xxHash-0.8.2-x86_64-1.txz

The documentation https://borgbackup.readthedocs.io/en/stable/installation.html#dependencies still says the libraries are bundled, should that be removed? By the way I love how accurate and detailed the documentation is, it helped me tremendously when building a custom Borg package for Unraid, based on Slackware. Thanks!

[ThomasWaldmann]

@kubedzero oops, yes, that's a docs bug, the docs were not updated about this change in borg 1.4.

I filed #8342 for it.