IMU Parameters Documentation #624
Conversation
|
Attach a PDF ? |
|
The PDF is attached. It is the last of the 3 files, or am I misreading your comment? |
There was a problem hiding this comment.
Sorry, but the table about units - which I gather is the only thing you added - does not make sense in this document. I encourage you to read the document (as I did, again, for the review), and then you'll see this table come as a complete surprise. Perhaps this table, which refers to variables in the IMU factor, should go as documentation in the code?
cmake/GtsamTesting.cmake
Outdated
| @@ -88,7 +88,7 @@ enable_testing() | |||
|
|
|||
| option(GTSAM_BUILD_TESTS "Enable/Disable building of tests" ON) | |||
| option(GTSAM_BUILD_EXAMPLES_ALWAYS "Build examples with 'make all' (build with 'make examples' if not)" ON) | |||
| option(GTSAM_BUILD_TIMING_ALWAYS "Build timing scripts with 'make all' (build with 'make timing' if not" OFF) | |||
| option(GTSAM_BUILD_TIMING_ALWAYS "Build timing scripts with 'make all' (build with 'make timing' if not" OFF) | |||
|
Feel free to merge and delete branch after checks passed :-) |
|
Don't you love how unicode lets us put all the math symbols directly in an easy-to-read manner? :D |
cmake/GtsamTesting.cmake
Outdated
| @@ -88,7 +88,7 @@ enable_testing() | |||
|
|
|||
| option(GTSAM_BUILD_TESTS "Enable/Disable building of tests" ON) | |||
| option(GTSAM_BUILD_EXAMPLES_ALWAYS "Build examples with 'make all' (build with 'make examples' if not)" ON) | |||
| option(GTSAM_BUILD_TIMING_ALWAYS "Build timing scripts with 'make all' (build with 'make timing' if not" OFF) | |||
| option(GTSAM_BUILD_TIMING_ALWAYS "Build timing scripts with 'make all' (build with 'make timing' if not" OFF) | |||
|
I'm pretty sure that this is incorrect: Vector3 biasAcc_; ///< The units for stddev are σ = m/s² or m √Hz/s²
Vector3 biasGyro_; ///< The units for stddev are σ = rad/s or rad √Hz/sIt should be: Vector3 biasAcc_; ///< The units for stddev are σ = m √Hz/s²
Vector3 biasGyro_; ///< The units for stddev are σ = rad √Hz/sSee my comment here for an in-depth explanation. |
|
@varunagrawal if you agree change it? |
Fixes #213