Clean up the __init__ #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import sys | ||
|
|
||
| from gtsam import gtsam, utils | ||
| from gtsam.gtsam import * |
There was a problem hiding this comment.
thanks for the PR @varunagrawal. While we're updating this, we probably want to remove this wildcard import too.
There was a problem hiding this comment.
This is needed, and I think is generally OK for pybind11 modules.
There was a problem hiding this comment.
Yup this is needed for proper functioning of the module.
ProfFan
requested changes
Oct 18, 2021
python/CMakeLists.txt
Outdated
|
|
||
| pybind_wrap(gtsam_py # target | ||
| pybind_wrap(${GTSAM_TARGET} # target |
There was a problem hiding this comment.
Ah great point!
python/CMakeLists.txt
Outdated
| @@ -122,7 +124,7 @@ if(GTSAM_UNSTABLE_BUILD_PYTHON) | |||
| gtsam::CameraSetCal3Fisheye | |||
| gtsam::KeyPairDoubleMap) | |||
|
|
|||
| pybind_wrap(gtsam_unstable_py # target | |||
| pybind_wrap(${GTSAM_UNSTABLE_TARGET} # target | |||
| import sys | ||
|
|
||
| from gtsam import gtsam, utils | ||
| from gtsam.gtsam import * |
There was a problem hiding this comment.
This is needed, and I think is generally OK for pybind11 modules.
ProfFan
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to do some wrapper clean up.