Skip to content

Week 4 Transcript

Neil Castelino edited this page Oct 22, 2018 · 5 revisions

Beginning of Class Updates

Important Notes to remember

  • Boris Tore his ACL
  • proceed with commonmark markdown rendering and switch to flexmark if we run into problems
  • if anyone is doing something they need to create a pull request to show when you are doing something. also update project board
  • commit small things often so that work done is not lost
  • where are we on getting our plugin view to have 2 windows open with file and rendered version of file? When you open up a .md file and select our editor (we have one) it opens another editor tab and then launches another tab that is the internal browser which renders an html file. Kristopher coded something that does this and will commit/push it after separating into multiple small chunks on different branches.

Boris: Integrated Sonar into Github to check for code smells, design flaws, etc. When you commit to a pull request you will receive two checks from Travis and Sonar. Need to start updating the project board more and move completed items to done. Don't accept your own pull requests.

Kris: tried to figure out how to open a local file in plugin view. Also figured out how to enable logging from the plugin editor to the editor that has the plugin running. Needs to make a pull request with new code associated with this.

Ibukun: worked on logging, then pulled kristophers changes in and stuff broke preventing continuing working on it. Will work with each other more closely to prevent this from happening again.

Andrew: Only pushed code from last week. going to work with Neil and Jiafeng to test rendering with commonmark

Jiafeng: worked with Neil on commonmark and flexmark. wrote tests for commonmark but still needs to push them. Need to figure out which tests are done and which tests need to be done.

Neil: Jiafeng and Neil looked up several different projects for rendering. Found Commonmark due to liscense and completeness. works with Maven and ran a few tests for it. Looked at the differences between GFM and commonmark. theres 4 extensions that github uses that are not in commonmark but are in flexmark (a fork of commonmark) flexmark is used by JetBrains. Need to decide if we should switch to flexmark or wait until tests are done with commonmark then try the ones we need in flexmark.

Clone this wiki locally