Port SCP's hashes into 64-bytes #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrejMitrovic
added
the
type-enhancement
Codecov Report
@@ Coverage Diff @@
## v0.x.x #737 +/- ##
==========================================
- Coverage 91.39% 91.36% -0.03%
==========================================
Files 63 63
Lines 5146 5120 -26
==========================================
- Hits 4703 4678 -25
+ Misses 443 442 -1
Continue to review full report at Codecov.
|
AndrejMitrovic
added
the
status-blocked
|
StellarHashFmt needs to be removed in SCPPrettyPrinter. |
AndrejMitrovic
force-pushed
the
64-byte-hashes
branch
from
45d66ef
to
3c8b876
Compare
AndrejMitrovic
removed
the
status-blocked
Done. |
AndrejMitrovic
added a commit
to AndrejMitrovic/agora
that referenced
this pull request
Apr 7, 2020
AndrejMitrovic
added a commit
to AndrejMitrovic/agora
that referenced
this pull request
Apr 7, 2020
AndrejMitrovic
changed the title
AndrejMitrovic
force-pushed
the
64-byte-hashes
branch
3 times, most recently
from
a9a264e
to
ab79669
Compare
AndrejMitrovic
commented
Apr 8, 2020
source/scpp/src/scp/SCPDriver.cpp
Outdated
| } | ||
| uint512 t = h->finish(); | ||
|
|
||
| // WARNING: Do not replace this back with SCP's original implementation. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
AndrejMitrovic
force-pushed
the
64-byte-hashes
branch
from
ab79669
to
0d458bf
Compare
6 tasks
Geod24
reviewed
Apr 8, 2020
| using uint256 = xdr::opaque_array<32>; | ||
| using uint512 = xdr::opaque_array<64>; |
There was a problem hiding this comment.
Can you add a comment above those types, explaining that they were modified on purpose ?
source/scpp/src/util/HashOfHash.cpp
Outdated
| @@ -3,7 +3,6 @@ | |||
|
|
|||
| namespace std | |||
| { | |||
|
|
|||
| // Plain SHA256 | ||
| uint256 | ||
| sha256(ByteSlice const& bin) | ||
| // Plain SHA512 |
There was a problem hiding this comment.
So I guess you want to do the migration in two steps ?
There was a problem hiding this comment.
I just realized this could have been all part of the same PR. But I'll leave it as is then, and fix up the comments.
AndrejMitrovic
added a commit
to AndrejMitrovic/agora
that referenced
this pull request
Apr 9, 2020
Also removed StellarHashFmt since we can just use prettify which supports 64-byte hashes already. Part of: bosagora#702
AndrejMitrovic
force-pushed
the
64-byte-hashes
branch
from
0d458bf
to
49cc23f
Compare
|
Fixed up, green. |
Geod24
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of resolving #702