Use our own hashing routines instead of SCPs #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrejMitrovic
added
status-blocked
|
Note: this is only for |
AndrejMitrovic
force-pushed
the
agora-hash
branch
2 times, most recently
from
2d72677
to
5ca40ca
Compare
Codecov Report
@@ Coverage Diff @@
## v0.x.x #741 +/- ##
==========================================
- Coverage 91.34% 91.34% -0.01%
==========================================
Files 64 65 +1
Lines 5151 5162 +11
==========================================
+ Hits 4705 4715 +10
- Misses 446 447 +1
Continue to review full report at Codecov.
|
6 tasks
AndrejMitrovic
commented
Apr 9, 2020
| @@ -24,14 +24,14 @@ LocalNode::LocalNode(NodeID const& nodeID, bool isValidator, | |||
| : mNodeID(nodeID), mIsValidator(isValidator), mQSet(qSet), mSCP(scp) | |||
| { | |||
| normalizeQSet(mQSet); | |||
| mQSetHash = sha512(xdr::xdr_to_opaque(mQSet)); | |||
| mQSetHash = getHashOf(mQSet); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
AndrejMitrovic
force-pushed
the
agora-hash
branch
3 times, most recently
from
7db6fcd
to
29222ff
Compare
AndrejMitrovic
changed the title
AndrejMitrovic
removed
the
status-blocked
TrustHenry
reviewed
Apr 9, 2020
source/agora/common/SCPHash.d
Outdated
| return uint512(hashFull(qset)); | ||
| } | ||
|
|
||
| /// ditto |
There was a problem hiding this comment.
It would be nice if D is uppercase.
There was a problem hiding this comment.
Okay! It doesn't make a difference to the compiler, but sure.
There was a problem hiding this comment.
Ah for consistency, sure.
|
I'll fix the linking issue in a bit. |
AndrejMitrovic
force-pushed
the
agora-hash
branch
3 times, most recently
from
4311e76
to
65f91b6
Compare
We want to use our own hashing routines when hashing SCPQuorumSet.
The ByteSlice bindings will be removed in the next commit.
AndrejMitrovic
force-pushed
the
agora-hash
branch
from
65f91b6
to
15582e6
Compare
|
I get linker errors with 1.20.1 but not 1.20.0. Sigh. |
SCP uses hashing in four different places, for different data types. So we're providing 4 prototoypes of the hashing routine implemented on the D side. Fixes: bosagora#702
AndrejMitrovic
force-pushed
the
agora-hash
branch
from
15582e6
to
a00fb51
Compare
|
Fixed the linker issue. |
Geod24
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Port SCP's hashes into 64-bytes #737Add @safe to quorum conversion functions #740Fixes #702