small touch ups #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anhosi
reviewed
Dec 6, 2018
| subscriptions_.clear(); | ||
| } | ||
|
|
||
| std::future<void> Recorder::launch_topics_discovery( | ||
| void Recorder::launch_topics_discovery( |
There was a problem hiding this comment.
If you move the async call out the function should no longer have launch in its name.
| @@ -44,38 +44,36 @@ void Recorder::record(const RecordOptions & record_options) | |||
|
|
|||
| std::future<void> discovery_future; | |||
| if (!record_options.is_discovery_disabled) { | |||
| discovery_future = launch_topics_discovery( | |||
| auto launch_discovery = std::bind( | |||
There was a problem hiding this comment.
i call the function directly because I don't see the point in calling a function which just wraps a lambda.
|
forgot rtps dynamic:
|
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the lambda out and touched up some white space.