Assert expected_params stubber
#784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to specify what parameters that you are to expect for a response and if they do not match, throw an error.
|
Nice! 🚢
Seems reasonable. It probably won't matter much in practice -- once a mismatch occurs, an exception is thrown and the test will likely halt at that point. |
| @@ -154,7 +176,13 @@ def add_client_error(self, method, service_error_code='', | |||
| } | |||
|
|
|||
| operation_name = self.client.meta.method_to_api_mapping.get(method) | |||
| response = (operation_name, (http_response, parsed_response)) | |||
| # Note that we do not allow for expected_params in the | |||
| # adding errors into the queue yet. | |||
There was a problem hiding this comment.
I would replace 'in the' with 'while'.
|
⛵ Nice! |
|
|
kyleknap
added a commit
that referenced
this pull request
Feb 8, 2016
Assert ``expected_params`` stubber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to specify what parameters that you are to expect for a response and if they do not match, throw an error.
I have been writing a fair amount of tests using this stubber. I have found this sort of response/expected_params matching as being pretty useful and was using it an awful lot.
The only behavior I am not sure about and would be up for opinions is what happens to the stubber's corresponding response when an
expected_paramsdoes not match. Should it use up the response in the queue? Or should it keep the original response in the queue so that it can be called later? I decided to go with the later because in the current stubber logic if there is a parameter validation error with the client, we will not pop the response off of the queue. So I thoughtexpected_paramswould have a similar expectation.cc @jamesls @mtdowling @rayluo @JordonPhillips