Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update twoliter to v0.0.4 #3480

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

webern
Copy link
Member

@webern webern commented Sep 20, 2023

TODO:

  • Aggregate additional Twoliter changes and release/use v0.0.4

Issue number:

bottlerocket-os/twoliter#55

Description of changes:

Update Twoliter:

  • Has testsys enhancements and fixes that we need
  • Moves declaration of SDK to Twoliter.toml
  • Makes it possible to turn on pubsys and testsys logging

Testing done:

  • cargo make works
  • cargo make ami works
  • cargo make test --help works

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@webern webern changed the title build: allow logging in pubsys and testsys build: update twoliter to v0.0.4 Sep 29, 2023
@webern webern force-pushed the logging branch 4 times, most recently from 4c8d0eb to cb0c745 Compare October 4, 2023 21:18
Has
- testsys fixes
- requires specification of the SDK in Twoliter.toml
- Adds logging functionality for pubsys and testsys
@webern
Copy link
Member Author

webern commented Oct 4, 2023

@webern webern marked this pull request as ready for review October 4, 2023 21:22
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending passing tests.

@webern
Copy link
Member Author

webern commented Oct 4, 2023

re-confirmed testing locally

@webern webern merged commit 17ce7ef into bottlerocket-os:develop Oct 4, 2023
48 checks passed
@webern webern deleted the logging branch October 4, 2023 21:48
@webern webern mentioned this pull request Oct 6, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants