Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bottles 51.10 broke launching programs from CLI or Desktop Entry #3210

Closed
Perkolator opened this issue Dec 24, 2023 · 9 comments · Fixed by #3211
Closed

[Bug]: Bottles 51.10 broke launching programs from CLI or Desktop Entry #3210

Perkolator opened this issue Dec 24, 2023 · 9 comments · Fixed by #3211

Comments

@Perkolator
Copy link

Perkolator commented Dec 24, 2023

Describe the bug

After updating to 51.10 I noticed that I was unable to start a game from a Desktop Entry. Trying to launch the game from the terminal with the same command as in the Desktop Entry, the following error happens:

$ flatpak run --command=bottles-cli com.usebottles.bottles run -p 'Dusk HD' -b 'Dusk' -- %u

17:38:08 (INFO) Forcing offline mode 
Traceback (most recent call last):
  File "/app/bin/bottles-cli", line 652, in <module>
    cli = CLI()
          ^^^^^
  File "/app/bin/bottles-cli", line 150, in __init__
    self.__process_args()
  File "/app/bin/bottles-cli", line 199, in __process_args
    self.run_program()
  File "/app/bin/bottles-cli", line 574, in run_program
    _args = program.get("arguments", "") + " " + _args
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

I removed the Desktop Entry from ~/.local/share/applications and created it again from the bottle, but the same problem persists.

To Reproduce

  1. Create a Desktop Entry for a program in a bottle and try to run it, or try starting a program in a bottle straight from the terminal

= error

Package

Flatpak from Flathub

Distribution

Mint 20.3 Cinnamon

Debugging Information

Official Package: true
Version: '51.10'
DE/WM: cinnamon
Display:
    X.org: true
    X.org (port): :99.0
    Wayland: false
Graphics:
    vendors:
        nvidia:
            vendor: nvidia
            envs:
                __NV_PRIME_RENDER_OFFLOAD: '1'
                __GLX_VENDOR_LIBRARY_NAME: nvidia
                __VK_LAYER_NV_optimus: NVIDIA_only
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/nvidia_icd.json
            nvngx_path: /usr/lib/x86_64-linux-gnu/GL/nvidia-535-129-03/extra/nvidia/wine
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 5.4.0-167-generic
Disk:
    Total: 8339161088
    Free: 8338980864
RAM:
    MemTotal: 15.5GiB
    MemAvailable: 5.2GiB
Bottles_envs: null

Troubleshooting Logs

No response

Additional context

No response

@mrceperka
Copy link

Got same problem. 51.10 as well. Fedora 38 Workstation.

@koplo199
Copy link
Contributor

koplo199 commented Dec 24, 2023

Nice catch, could affected users check if #3211 indeed fix the issue? Build artifacts should soon be available here.

Edit: Adding --args-replace after the second run in the above command line should theoretically serve the same purpose, without the need to install any artifact.

@Perkolator
Copy link
Author

@koplo199 both tested, both work. Nice quick fix. :)

@koplo199
Copy link
Contributor

And thanks for the confirmation ;)

@isitLoVe
Copy link

Also fixed the launch from Steam on Steam Deck for me

@Kagukara
Copy link

Kagukara commented Feb 1, 2024

Just ran into this issue on the Steam Deck and this comment suggesting to add "--args-replace after the second run" fixed it.

Edit: Adding --args-replace after the second run in the above command line should theoretically serve the same purpose, without the need to install any artifact.
Comment: #3210 (comment)

When will a fix get released so this doesn't keep happening? My current bottles flatpak is on Version: '51.10'.

@Perkolator
Copy link
Author

When will a fix get released so this doesn't keep happening?

My thoughts exactly, this is the kind of bug that would warrant a "dotfix" release. As one can see from this issue, there's been many duplicate (and one(/some?) related) issues opened.

@Stephenm64
Copy link

I encountered this bug by happenstance with my first attempt at trying out bottles. it was really frustrating, releasing an update with the fixes asap would be highly appreciated.

@Laserlicht
Copy link

Same problem here... How to fix it in steam ui with xdg-open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants