Limit maximum amount of bytes to read, fixes #216 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of rand() can be numbers of up to 2147483647 (PHP 7.3.14 on macOS). Before the actual file read PHP allocates the amount of memory specified by the second argument to fread() to ensure everything fits into memory. For unit tests that's bad, as it can mean of allocating 2 GB of memory. Therefore this fix limits the amount to 10000. For typical vfsStream usages that's more than sufficient. The usage of rand() is kept to verify that the functionality tested works independent of the amount of bytes to be read from the file.
mikey179
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
rand()can be numbers of up to 2147483647 (PHP 7.3.14 on macOS). Before the actual file read PHP allocates the amount of memory specified by the second argument tofread()to ensure everything fits into memory. For unit tests that's bad, as it can mean allocating 2 GB of memory.Therefore this fix limits the amount to 10000. For typical vfsStream usages that's more than sufficient. The usage of
rand()is kept to verify that the functionality tested works independent of the amount of bytes to be read from the file.