Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize GitHub urls #7

Closed
sindresorhus opened this issue Jan 17, 2013 · 1 comment · Fixed by #82
Closed

Normalize GitHub urls #7

sindresorhus opened this issue Jan 17, 2013 · 1 comment · Fixed by #82

Comments

@sindresorhus
Copy link
Contributor

Server should have some custom logic for GitHub to normalize urls to prevent duplicates and return consistent urls.

All these are valid GitHub clone urls:

git://github.com/sakabako/scrollMonitor.git
git://github.com/sakabako/scrollMonitor
https://github.com/sakabako/scrollMonitor.git
https://github.com/sakabako/scrollMonitor
git@github.com:sakabako/scrollMonitor.git
git@github.com:sakabako/scrollMonitor # not sure about this

They should be saved to one format.

@satazor
Copy link
Member

satazor commented May 5, 2013

I've made similar normalisation in the rewrite.

Trailing slashes should also be normalised:

git://github.com/sakabako/scrollMonitor.git/ -> git://github.com/sakabako/scrollMonitor.git
git://github.com/sakabako/scrollMonitor/ -> git://github.com/sakabako/scrollMonitor.git

patrickkettner added a commit to patrickkettner/registry that referenced this issue Jul 26, 2014
patrickkettner added a commit to patrickkettner/registry that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants