Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use alpine:3.20 #470

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

coiouhkc
Copy link
Contributor

Update Dockerfile to use alpine:3.20 both for builder and resulting image, caused by aquasec/trivy vuln. scanner issues with git, see #469

@boyter
Copy link
Owner

boyter commented May 26, 2024

Cheers for that.

@boyter boyter merged commit 624d6c5 into boyter:master May 26, 2024
3 of 4 checks passed
@coiouhkc
Copy link
Contributor Author

Thanks for merging! When do you plan to release a new version of the docker image?

@boyter
Copy link
Owner

boyter commented May 27, 2024

I don't actually have control of that... I don't think... unless its something done in github somehow. If thats the case let me know how and ill do it instantly.

@coiouhkc
Copy link
Contributor Author

@boyter - i thought you merged the feature from https://github.com/lhoupert/scc-in-docker (also https://github.com/lhoupert/scc and #425), at least i see a pipeline at https://github.com/boyter/scc/blob/master/.github/workflows/docker-publish.yml

I initially used the docker image of @lhoupert, but i'm not sure, whether https://github.com/lhoupert/scc is still maintained.

@boyter
Copy link
Owner

boyter commented May 27, 2024

Well my lack of github knowledge is showing here. Ill have to have a look to see what I need to do in that case.

@dbaggerman
Copy link
Collaborator

@boyter, your docker images are listed here: https://github.com/boyter/scc/pkgs/container/scc

Looks like it's based on the release version, so a 3.3.5 version would get built with the updated dockerfile.

@lhoupert
Copy link
Contributor

@boyter - i thought you merged the feature from https://github.com/lhoupert/scc-in-docker (also https://github.com/lhoupert/scc and #425), at least i see a pipeline at https://github.com/boyter/scc/blob/master/.github/workflows/docker-publish.yml

I initially used the docker image of @lhoupert, but i'm not sure, whether https://github.com/lhoupert/scc is still maintained.

Hi I am not maintaining this fork, it was mostly to build and test my PR. I will archive it to avoid confusion.

@boyter
Copy link
Owner

boyter commented May 28, 2024

Neat so nothing for me to do then. Perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants