Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new TaskManager.setTimer() function #872

Closed
AndrejMitrovic opened this issue May 26, 2020 · 5 comments
Closed

Use the new TaskManager.setTimer() function #872

AndrejMitrovic opened this issue May 26, 2020 · 5 comments
Assignees
Labels
Story-Points:3 This takes 1 to 3 days to complete type-refactoring An improvement on existing code without visible functional change
Milestone

Comments

@AndrejMitrovic AndrejMitrovic added the type-refactoring An improvement on existing code without visible functional change label May 26, 2020
@Geod24
Copy link
Collaborator

Geod24 commented May 26, 2020

setTimer available as of #860

@Geod24 Geod24 added this to the 2. Validator milestone Jun 2, 2020
@TrustHenry
Copy link
Member

https://github.com/bpfkorea/agora/blob/bebe6555052b830bff1040847edd035046d24cd4/source/agora/network/NetworkManager.d#L203-L210
https://github.com/bpfkorea/agora/blob/bebe6555052b830bff1040847edd035046d24cd4/source/agora/network/NetworkManager.d#L235-L246

Here's the question.
If it look at the existing code, wait after the function is done.
For the new function localrest, first wait and then call delegate.
Would it be okay to do the two things mentioned here after wait and call?

This creates a subtle time difference at the beginning.

@AndrejMitrovic
Copy link
Contributor Author

Please be aware you're pointing to outdated commits.

Also yes, there's a difference. We probably don't want to delay every request. It would be nice to be able to do start + wait rather than just wait + start.

@AndrejMitrovic AndrejMitrovic changed the title Use the new setTimer function in LocalRest Use the new TaskManager.setTimer() function Jun 2, 2020
@TrustHenry
Copy link
Member

The setTimer() also requires the stop function.

@bpalaggi bpalaggi added the Story-Points:3 This takes 1 to 3 days to complete label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Story-Points:3 This takes 1 to 3 days to complete type-refactoring An improvement on existing code without visible functional change
Projects
None yet
Development

No branches or pull requests

4 participants