Skip to content

Added type annotations to curtsiesfrontend/interpreter.py: BPythonFormatter.format() #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

amuletcoin
Copy link

@amuletcoin amuletcoin commented Jun 9, 2022

Finished adding type hints to curtsiesfrontend/interpreter.py's functions, specifically the BPythonFormatter class's format() method.

@amuletcoin amuletcoin changed the title Added type annotations to BPythonFormatter.format() Added type annotations to curtsiesfrontend/interpreter.py: BPythonFormatter.format() Jun 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #961 (5df8754) into main (f076f32) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   68.76%   68.74%   -0.03%     
==========================================
  Files          63       63              
  Lines        9524     9524              
==========================================
- Hits         6549     6547       -2     
- Misses       2975     2977       +2     
Impacted Files Coverage Δ
bpython/curtsiesfrontend/interpreter.py 100.00% <100.00%> (ø)
bpython/repl.py 73.79% <0.00%> (-0.28%) ⬇️
bpython/test/test_importcompletion.py 92.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f076f32...5df8754. Read the comment docs.

@sebastinas sebastinas self-requested a review June 20, 2022 08:20
@sebastinas sebastinas closed this Jun 20, 2022
@sebastinas sebastinas reopened this Jun 20, 2022
@sebastinas
Copy link
Contributor

Sorry, miss clicked.

The black regression is easy to fix afterwards, but the mypy regressions needs to be fixed before this can go forward.

@amuletcoin amuletcoin closed this by deleting the head repository Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants