broken selection via mouse rect.

[lynxlynxlynx]

just so it's not forgotten: 5a04992 is to blame.

[bradallred]

I dont understand how that would break that. surely GameControl::ChangeMap ought to disable event handling and also reset the mouse state. You sure its not something else?

[lynxlynxlynx]

Yeah, established through bisect. You can revert it and see for yourself. Like I said in the comment, my guess is that now nothing is turning off SF_DISABLEMOUSE... But that doesn't really seem to be the case - the code looks ok and the cursor is still visible and enabled.

[bradallred]

ok, so something else somewhere might be setting SF_CUTSCENE, SF_DISABLEMOUSE and must have been relying on this to clear it... thats the only thing i can think of if the cursor isn't greyed.

the question is, should GameControl::ChangeMap do anything if we are in a cutscene? if it is allowed then I suppose changing map ought to clear that.

to me, it doesn't seem like changing map during a cutscene is valid behavior, but I may be wrong (do any cutscenes span multiple areas?)

[lynxlynxlynx]

Why would the cursor be grayed without SF_DISABLEMOUSE being set?

Cutscenes regularly change maps and the function is of course needed. ChangeMap is probably called while starting/loading a game too.

[bradallred]

IIRC if the disabled flag on a view is set you will get a greyed cursor too. In fact it may be the only thing that does it anymore.

[lynxlynxlynx]

ChangeMap is usually (if not always) over before you could see that.

[bradallred]

ok, I dont know if it will resolve the issue, but if this is called via cutscene and it was previously clearing that flag, then we should call SetCutSceneMode(false) at the beginning (or end since thats where it was before)

[lynxlynxlynx]

No, this is a dead end. In master it's not playing with any of this.

[bradallred]

now it makes even less sense :)

I now have to suspect ClearMouseState() somehow getting things stuck

[lynxlynxlynx]

it does, yes. Commenting that out is enough to get the rect back. :)

[bradallred]

still, that shouldn't have that result... ClearMouseState() should at worst reset things such that another click and drag ought to work.

seems to indicate some other problem somewhere. Probably one thing we should do is have GC disabled at construction time and only become enabled once a map is loaded.

[bradallred]

problem is simply that GameControl::ChangeMap doesn't always change the map :)

this is apparently called from the game loop every iteration too :(