Update Galea board using production specifications #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retiutut
changed the title
Andrey1994
reviewed
Oct 7, 2025
| { | ||
| std::stringstream gains; | ||
|
|
||
| for (int i = 0; i < 20; i++) |
There was a problem hiding this comment.
why is it 20? would be better to dont hardcode the value but check the lenght of the vector instead
There was a problem hiding this comment.
you can also make it the same for cyton
There was a problem hiding this comment.
you can add method to return a string straight to gain tracker class, check the size there and just call this method from galea and cyton from config_board
| {"timestamp_channel", 27}, | ||
| {"marker_channel", 28}, | ||
| {"num_rows", 29}, | ||
| {"eeg_channels", {9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}}, |
There was a problem hiding this comment.
if I count correctly, eeg + emg + eog here is 24 channels. In gain tracker in one place its 20 and in parsing code its 28 in one place, have you double checked it?
There was a problem hiding this comment.
ah, sorry, its 28 byt starts from 4, so 24 is correct, why 20 in gain tracker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #783
Fixes #784