fix: Setting offset breaks "centered" #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use padding instead of margin for CarouselItem.js to avoid spacing issues with box sizing: border-box Signed-off-by: mhatvan <markus_hatvan@aon.at>
piotr-s-brainhub
changed the base branch from
master
to
fix/pr-593-mhatvan-394-setting-offset-breaks-centered
|
Unfortunately I didn't know about the branch naming conventions. |
piotr-s-brainhub
approved these changes
Jul 13, 2020
piotr-s-brainhub
merged commit 009989d
into
brainhubeu:fix/pr-593-mhatvan-394-setting-offset-breaks-centered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #394.
After a long discussion in the issue, we decided to change from usage of padding to margin to work around spacing issues with
box-sizing: border-box, which could be set by css resets or css frameworks by default.IssueHunt Summary
Referenced issues
This pull request has been submitted to: