Fix/pr 593 mhatvan 394 setting offset breaks centered #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use padding instead of margin for CarouselItem.js to avoid spacing issues with box sizing: border-box Signed-off-by: mhatvan <markus_hatvan@aon.at>
fix: Setting offset breaks "centered"
|
It looks good: in contrary to the current behavior: |
|
I checked it doesn't break anything (desktop & mobile) and the example with offset and centered works correctly on mobile. |
RobertHebel
approved these changes
Jul 14, 2020
piotr-s-brainhub
deleted the
fix/pr-593-mhatvan-394-setting-offset-breaks-centered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed to https://beghp.github.io/gh-pages-rc-5
It fixes #394
- [x] an issue linked to the PR