Add threads options. #150
Closed
Add threads options. #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason this PR was never merged? Would be helpful to be able to use threads with this library |
|
@bramp on the above |
|
ability to specify threads is very useful |
drallgood
reviewed
Aug 19, 2023
|
|
||
| public FFmpegBuilder setFormat(String format) { | ||
| public FFmpegBuilder setThreads(int threads) { | ||
| checkArgument(threads != 0, "threads must be greater than zero"); |
There was a problem hiding this comment.
Good catch. Please make the change.
|
Looks good other than one minor change. |
Merged
|
Fixed in #303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.