Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 23 #29

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Issue 23 #29

merged 2 commits into from
Feb 10, 2020

Conversation

egolol
Copy link
Collaborator

@egolol egolol commented Feb 10, 2020

#23 Created a unit test for symmetrize.m

#23 Created a unit test for symmetrize
@egolol egolol added the test Unit tests label Feb 10, 2020
@egolol egolol self-assigned this Feb 10, 2020
Copy link
Member

@giovannivolpe giovannivolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add all missing cases, just to be sure that it works:
'average', 'or', etc...

3 2 1
];

%% Test 1: Symmetrize Default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%% Test 1: Symmetrize 'Max' (Default)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to %% Test 1: Symmetrize Max Default because when test runs the output is weird because of special characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

'BRAPH:symmetrize:Bug',...
'Symmetrize default case not working correctly')

%% Test 2: Symmetrize Sum Add
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%% Test 2: Symmetrize 'Add'

6 3 2;
]),...
'BRAPH:symmetrize:Bug',...
'Symmetrize sum, add case not working correctly')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Symmetrize 'add' case not working correctly')

]),...
'BRAPH:symmetrize:Bug',...
'Symmetrize sum, add case not working correctly')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Symmetrize 'Sum' case

3 2 1;
]),...
'BRAPH:symmetrize:Bug',...
'Symmetrize default case not working correctly')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Symmetrize 'max' case (default) not working correctly')

#23 Added more test cases, and changed message.
@giovannivolpe giovannivolpe merged commit a5cbc0a into develop Feb 10, 2020
@giovannivolpe giovannivolpe deleted the 23-eg-test_symmetrize branch February 10, 2020 22:36
@giovannivolpe giovannivolpe mentioned this pull request Feb 10, 2020
@egolol egolol restored the 23-eg-test_symmetrize branch February 11, 2020 08:49
@egolol egolol deleted the 23-eg-test_symmetrize branch February 11, 2020 08:50
giovannivolpe added a commit that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants