Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract translations #1181

Merged
merged 1 commit into from
May 1, 2024
Merged

fix: extract translations #1181

merged 1 commit into from
May 1, 2024

Conversation

tackley
Copy link
Collaborator

@tackley tackley commented May 1, 2024

Apparently if you don't do this you get junk displayed after deployment. Going forward we need to make this less error-prone. But for now just run npm run extract.

Also fix a typo that I noticed while reviewing.

Screenshot 2024-05-01 at 17 30 51

Apparently if you don't do this you get junk displayed after deployment. Going forward we need to make this less error-prone. But for now just run `npm run extract`.

Also fix a typo that I noticed while reviewing.
@tackley tackley requested a review from a team as a code owner May 1, 2024 16:37
Copy link

github-actions bot commented May 1, 2024

[puLL-Merge] - brave/ads-ui@1181

Description

This PR makes changes to the user interface for the search advertising setup flow. It adds new components and sections for reviewing the advertiser profile, selected ads, landing page details, and query parameters. The motivation seems to be to provide a more guided and detailed setup process for advertisers creating search campaigns.

Changes

Changes

Translations (src/locales/*.po):

  • Adds new translations for labels and text used in the new setup flow components
  • Updates some existing translations that were moved to new components

src/user/views/user/search/SetupProgress.tsx:

  • Adds a new SetupProgress component that shows the overall progress and steps in the search campaign setup flow

src/user/views/user/search/Finalize.tsx:

  • Adds a new Finalize component for the final setup step
  • Includes sections to add notes for the account manager and review query string parameters that will be appended to landing page URLs for tracking
  • Fixes a typo in the query parameters section title

src/user/views/user/search/LandingPageDetail.tsx:

  • Adds inputs for the full landing page URL and sample search queries

src/user/views/user/search/SummaryPanel.tsx:

  • Renames the existing Summary component to SummaryPanel
  • Adds a section to display the selected ads

Security Hotspots

  1. Appending arbitrary query parameters to advertiser landing page URLs could potentially be abused if not properly validated and sanitized. The values should be strictly checked to prevent injection of malicious scripts or URLs.

  2. The notes field where advertisers can enter free text to send to the account manager should have its contents sanitized and scanned for potential spam or abusive language before storing and displaying to the recipient.

  3. Any new form inputs added, like the landing page URL, should have strict validation and error handling to prevent malformed data from being submitted.

@tackley tackley merged commit d27655a into master May 1, 2024
8 checks passed
@tackley tackley deleted the fix/extract-translations branch May 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants