Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production Release 2024-05-02 #1180

Merged
merged 4 commits into from
May 2, 2024
Merged

Production Release 2024-05-02 #1180

merged 4 commits into from
May 2, 2024

Conversation

tackley
Copy link
Collaborator

@tackley tackley commented May 1, 2024 •
edited by github-actions bot
Loading

@tackley
feat: basic search ad selection (#1175)
dcb9731 
This isn't hooked up to any flows yet, and is only usable by admins, but
lets us explore this functionality.


https://github.com/brave/ads-ui/assets/51444/dd5c1544-3b67-400a-a832-8a31c0e8b4ab
@github-actions github-actions bot changed the title next prod release Production Release 2024-05-01 May 1, 2024
@tackley
fix: extract translations (#1181)
d27655a 
Apparently if you don't do this you get junk displayed after deployment.
Going forward we need to make this less error-prone. But for now just
run `npm run extract`.

Also fix a typo that I noticed while reviewing.

<img width="952" alt="Screenshot 2024-05-01 at 17 30 51"
src="https://github.com/brave/ads-ui/assets/51444/8bf1af8e-6ad1-4159-9ffe-5d4af45d7834">
@renovate
chore(deps): update all non-major dependencies (#1179)
5403aeb 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update | Pending |
|---|---|---|---|---|---|---|---|---|
| [@fontsource/mulish](https://fontsource.org/fonts/mulish)
([source](https://togithub.com/fontsource/font-files/tree/HEAD/fonts/google/mulish))
| [`5.0.17` ->
`5.0.18`](https://renovatebot.com/diffs/npm/@fontsource%2fmulish/5.0.17/5.0.18)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fontsource%2fmulish/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fontsource%2fmulish/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fontsource%2fmulish/5.0.17/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fontsource%2fmulish/5.0.17/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | patch | |
| [@fontsource/poppins](https://fontsource.org/fonts/poppins)
([source](https://togithub.com/fontsource/font-files/tree/HEAD/fonts/google/poppins))
| [`5.0.13` ->
`5.0.14`](https://renovatebot.com/diffs/npm/@fontsource%2fpoppins/5.0.13/5.0.14)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fontsource%2fpoppins/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fontsource%2fpoppins/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fontsource%2fpoppins/5.0.13/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fontsource%2fpoppins/5.0.13/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | patch | |
| [@mui/x-data-grid](https://mui.com/x/react-data-grid/)
([source](https://togithub.com/mui/mui-x/tree/HEAD/packages/x-data-grid))
| [`7.3.0` ->
`7.3.1`](https://renovatebot.com/diffs/npm/@mui%2fx-data-grid/7.3.0/7.3.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2fx-data-grid/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2fx-data-grid/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2fx-data-grid/7.3.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2fx-data-grid/7.3.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | patch | |
| [@mui/x-date-pickers](https://mui.com/x/react-date-pickers/)
([source](https://togithub.com/mui/mui-x/tree/HEAD/packages/x-date-pickers))
| [`7.2.0` ->
`7.3.1`](https://renovatebot.com/diffs/npm/@mui%2fx-date-pickers/7.2.0/7.3.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2fx-date-pickers/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2fx-date-pickers/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2fx-date-pickers/7.2.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2fx-date-pickers/7.2.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | minor | |
|
[@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react))
| [`18.2.79` ->
`18.3.1`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.79/18.3.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/18.2.79/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/18.2.79/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor | |
|
[@types/react-dom](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom))
| [`18.2.25` ->
`18.3.0`](https://renovatebot.com/diffs/npm/@types%2freact-dom/18.2.25/18.3.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact-dom/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact-dom/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact-dom/18.2.25/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact-dom/18.2.25/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor | |
|
[@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin)
([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin))
| [`7.7.0` ->
`7.7.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/7.7.0/7.7.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2feslint-plugin/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2feslint-plugin/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch | `7.8.0` |
|
[@typescript-eslint/parser](https://typescript-eslint.io/packages/parser)
([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser))
| [`7.7.0` ->
`7.7.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/7.7.0/7.7.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2fparser/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2fparser/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch | `7.8.0` |
| [actions/checkout](https://togithub.com/actions/checkout) | `v4.1.3`
-> `v4.1.4` |
[![age](https://developer.mend.io/api/mc/badges/age/github-tags/actions%2fcheckout/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/actions%2fcheckout/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/actions%2fcheckout/v4.1.3/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/actions%2fcheckout/v4.1.3/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| action | patch | |
| [formik](https://formik.org)
([source](https://togithub.com/jaredpalmer/formik)) | [`2.4.5` ->
`2.4.6`](https://renovatebot.com/diffs/npm/formik/2.4.5/2.4.6) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/formik/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/formik/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/formik/2.4.5/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/formik/2.4.5/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | patch | |
| [github/codeql-action](https://togithub.com/github/codeql-action) |
`v3.25.1` -> `v3.25.3` |
[![age](https://developer.mend.io/api/mc/badges/age/github-tags/github%2fcodeql-action/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/github%2fcodeql-action/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/github%2fcodeql-action/v3.25.1/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/github%2fcodeql-action/v3.25.1/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| action | patch | |
| [react](https://reactjs.org/)
([source](https://togithub.com/facebook/react/tree/HEAD/packages/react))
| [`18.2.0` ->
`18.3.1`](https://renovatebot.com/diffs/npm/react/18.2.0/18.3.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/react/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | minor | |
| [react-dom](https://reactjs.org/)
([source](https://togithub.com/facebook/react/tree/HEAD/packages/react-dom))
| [`18.2.0` ->
`18.3.1`](https://renovatebot.com/diffs/npm/react-dom/18.2.0/18.3.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-dom/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-dom/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-dom/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-dom/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| dependencies | minor | |
| [vitest](https://togithub.com/vitest-dev/vitest)
([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vitest))
| [`1.5.0` ->
`1.5.2`](https://renovatebot.com/diffs/npm/vitest/1.5.0/1.5.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/vitest/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vitest/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vitest/1.5.0/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vitest/1.5.0/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch | `1.5.3` |

---

### Release Notes

<details>
<summary>fontsource/font-files (@&#8203;fontsource/mulish)</summary>

###
[`v5.0.18`](https://togithub.com/fontsource/font-files/compare/643d5496631adb16c66ab3fc2f9e128d01817307...f069547c3d25cb9602fdbc1d9eb1f34046dc8353)

[Compare
Source](https://togithub.com/fontsource/font-files/compare/643d5496631adb16c66ab3fc2f9e128d01817307...f069547c3d25cb9602fdbc1d9eb1f34046dc8353)

</details>

<details>
<summary>fontsource/font-files (@&#8203;fontsource/poppins)</summary>

###
[`v5.0.14`](https://togithub.com/fontsource/font-files/compare/fd9fe9317a4ab7042845961a60b1cace22dc14d6...f069547c3d25cb9602fdbc1d9eb1f34046dc8353)

[Compare
Source](https://togithub.com/fontsource/font-files/compare/fd9fe9317a4ab7042845961a60b1cace22dc14d6...f069547c3d25cb9602fdbc1d9eb1f34046dc8353)

</details>

<details>
<summary>mui/mui-x (@&#8203;mui/x-data-grid)</summary>

###
[`v7.3.1`](https://togithub.com/mui/mui-x/blob/HEAD/CHANGELOG.md#731)

[Compare Source](https://togithub.com/mui/mui-x/compare/v7.3.0...v7.3.1)

*Apr 26, 2024*

We'd like to offer a big thanks to the 13 contributors who made this
release possible. Here are some highlights ✨:

- 🎁 Scatter Charts get a [z-axis to allow coloring data points
independently from their
coordinates](https://mui.com/x/react-charts/scatter/#color-scale)
- 🌍 Improve Catalan (ca-ES) and Spanish (es-ES) locales on the Date and
Time Pickers
-   🐞 Bugfixes
-   📚 Documentation improvements

##### Data Grid

##### `@mui/x-data-grid@7.3.1`

- \[DataGrid] Fix date filtering for negative timezone offsets
([#&#8203;12836](https://togithub.com/mui/mui-x/issues/12836))
[@&#8203;cherniavskii](https://togithub.com/cherniavskii)
- \[DataGrid] Fix flex column width when used with pinned columns
([#&#8203;12849](https://togithub.com/mui/mui-x/issues/12849))
[@&#8203;romgrk](https://togithub.com/romgrk)
- \[DataGrid] Fix group header resize
([#&#8203;12863](https://togithub.com/mui/mui-x/issues/12863))
[@&#8203;arminmeh](https://togithub.com/arminmeh)
- \[DataGrid] Pass slot props to `columnHeaders` slot
([#&#8203;12768](https://togithub.com/mui/mui-x/issues/12768))
[@&#8203;cherniavskii](https://togithub.com/cherniavskii)

##### `@mui/x-data-grid-pro@7.3.1`
[![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link
"Pro plan")

Same changes as in `@mui/x-data-grid@7.3.1`.

##### `@mui/x-data-grid-premium@7.3.1`
[![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link
"Premium plan")

Same changes as in `@mui/x-data-grid-pro@7.3.1`.

##### Date and Time Pickers

##### `@mui/x-date-pickers@7.3.1`

- \[l10n] Improve Catalan (ca-ES) locale
([#&#8203;12856](https://togithub.com/mui/mui-x/issues/12856))
[@&#8203;soler1212](https://togithub.com/soler1212)
- \[l10n] Improve Spanish (es-ES) locale
([#&#8203;12858](https://togithub.com/mui/mui-x/issues/12858))
[@&#8203;soler1212](https://togithub.com/soler1212)

##### `@mui/x-date-pickers-pro@7.3.1`
[![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link
"Pro plan")

Same changes as in `@mui/x-date-pickers@7.3.1`.

##### Charts

##### `@mui/x-charts@7.3.1`

- \[charts] Add documentation on border radius alternative for
`BarCharts`
([#&#8203;12859](https://togithub.com/mui/mui-x/issues/12859))
[@&#8203;JCQuintas](https://togithub.com/JCQuintas)
- \[charts] Add z-axis to colorize scatter charts
([#&#8203;12738](https://togithub.com/mui/mui-x/issues/12738))
[@&#8203;alexfauquette](https://togithub.com/alexfauquette)
- \[charts] Fix left/bottomAxis not picking up default axis id
([#&#8203;12894](https://togithub.com/mui/mui-x/issues/12894))
[@&#8203;JCQuintas](https://togithub.com/JCQuintas)
- \[charts] Improve default tooltip content
([#&#8203;12257](https://togithub.com/mui/mui-x/issues/12257))
[@&#8203;oliviertassinari](https://togithub.com/oliviertassinari)
- \[charts] Round y values for bar chart
([#&#8203;12846](https://togithub.com/mui/mui-x/issues/12846))
[@&#8203;alexfauquette](https://togithub.com/alexfauquette)

##### Tree View

##### `@mui/x-tree-view@7.3.1`

- \[TreeView] Remove un-needed `aria-activedescendant` attribute
([#&#8203;12867](https://togithub.com/mui/mui-x/issues/12867))
[@&#8203;flaviendelangle](https://togithub.com/flaviendelangle)
- \[TreeView] Rework the selection internals
([#&#8203;12703](https://togithub.com/mui/mui-x/issues/12703))
[@&#8203;flaviendelangle](https://togithub.com/flaviendelangle)
- \[TreeView] Use the order in which the items are displayed for
`type-ahead`
([#&#8203;12827](https://togithub.com/mui/mui-x/issues/12827))
[@&#8203;flaviendelangle](https://togithub.com/flaviendelangle)

##### Docs

- \[docs] Add demo for styling charts with `sx` props
([#&#8203;12791](https://togithub.com/mui/mui-x/issues/12791))
[@&#8203;derek-0000](https://togithub.com/derek-0000)
- \[docs] Cover webpack 4 support in migration guide
([#&#8203;12710](https://togithub.com/mui/mui-x/issues/12710))
[@&#8203;cherniavskii](https://togithub.com/cherniavskii)
- \[docs] Document interfaces for charts
([#&#8203;12656](https://togithub.com/mui/mui-x/issues/12656))
[@&#8203;alexfauquette](https://togithub.com/alexfauquette)
- \[docs] Fix Vale regression
([#&#8203;12862](https://togithub.com/mui/mui-x/issues/12862))
[@&#8203;oliviertassinari](https://togithub.com/oliviertassinari)
- \[docs] Improve Data Grid migration guide
([#&#8203;12879](https://togithub.com/mui/mui-x/issues/12879))
[@&#8203;MBilalShafi](https://togithub.com/MBilalShafi)
- \[docs] Update Column features availability
([#&#8203;12865](https://togithub.com/mui/mui-x/issues/12865))
[@&#8203;DanailH](https://togithub.com/DanailH)

##### Core

- \[core] Fix `l10n` GH workflow
([#&#8203;12895](https://togithub.com/mui/mui-x/issues/12895))
[@&#8203;LukasTy](https://togithub.com/LukasTy)
- \[core] Match Base UI and Toolpad
[@&#8203;oliviertassinari](https://togithub.com/oliviertassinari)
- \[core] Remove redundant `setupFiles` entries in `package.json`
([#&#8203;12899](https://togithub.com/mui/mui-x/issues/12899))
[@&#8203;LukasTy](https://togithub.com/LukasTy)
- \[core] Use `describeTreeView` for focus tests
([#&#8203;12698](https://togithub.com/mui/mui-x/issues/12698))
[@&#8203;flaviendelangle](https://togithub.com/flaviendelangle)
- \[core] Use `describeTreeView` for type-ahead tests
([#&#8203;12811](https://togithub.com/mui/mui-x/issues/12811))
[@&#8203;flaviendelangle](https://togithub.com/flaviendelangle)
- \[code-infra] Change package manager to `pnpm`
([#&#8203;11875](https://togithub.com/mui/mui-x/issues/11875))
[@&#8203;LukasTy](https://togithub.com/LukasTy)
- \[code-infra] Closer sync with eslint config of codebase
([#&#8203;12864](https://togithub.com/mui/mui-x/issues/12864))
[@&#8203;oliviertassinari](https://togithub.com/oliviertassinari)
- \[support-infra] Add release announcement to GitHub workflows
([#&#8203;11867](https://togithub.com/mui/mui-x/issues/11867))
([#&#8203;12843](https://togithub.com/mui/mui-x/issues/12843))
[@&#8203;michelengelen](https://togithub.com/michelengelen)

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/eslint-plugin)</summary>

###
[`v7.7.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#771-2024-04-22)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.7.0...v7.7.1)

##### 🩹 Fixes

- **eslint-plugin:** \[no-unsafe-assignment] handle shorthand property
assignment

- **eslint-plugin:** \[explicit-function-return-type] fix checking wrong
ancestor's return type

- **eslint-plugin:** \[prefer-optional-chain] only look at left operand
for `requireNullish`

-   **eslint-plugin:** \[no-for-in-array] refine report location

- **eslint-plugin:** \[no-unnecessary-type-assertion] allow non-null
assertion for void type

##### ❤️  Thank You

-   Abraham Guo
-   Kirk Waiblinger
-   YeonJuan

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/parser)</summary>

###
[`v7.7.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#771-2024-04-22)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.7.0...v7.7.1)

This was a version bump only for parser to align it with other projects,
there were no code changes.

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

<details>
<summary>actions/checkout (actions/checkout)</summary>

###
[`v4.1.4`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v414)

[Compare
Source](https://togithub.com/actions/checkout/compare/v4.1.3...v4.1.4)

- Disable `extensions.worktreeConfig` when disabling `sparse-checkout`
by [@&#8203;jww3](https://togithub.com/jww3) in
[https://github.com/actions/checkout/pull/1692](https://togithub.com/actions/checkout/pull/1692)
- Add dependabot config by
[@&#8203;cory-miller](https://togithub.com/cory-miller) in
[https://github.com/actions/checkout/pull/1688](https://togithub.com/actions/checkout/pull/1688)
- Bump the minor-actions-dependencies group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/actions/checkout/pull/1693](https://togithub.com/actions/checkout/pull/1693)
- Bump word-wrap from 1.2.3 to 1.2.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/actions/checkout/pull/1643](https://togithub.com/actions/checkout/pull/1643)

</details>

<details>
<summary>jaredpalmer/formik (formik)</summary>

###
[`v2.4.6`](https://togithub.com/jaredpalmer/formik/compare/formik@2.4.5...c798145e2307b0273ea4d9c6bfd8250f28d95be9)

[Compare
Source](https://togithub.com/jaredpalmer/formik/compare/formik@2.4.5...formik@2.4.6)

</details>

<details>
<summary>github/codeql-action (github/codeql-action)</summary>

###
[`v3.25.3`](https://togithub.com/github/codeql-action/compare/v3.25.2...v3.25.3)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v3.25.2...v3.25.3)

###
[`v3.25.2`](https://togithub.com/github/codeql-action/compare/v3.25.1...v3.25.2)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v3.25.1...v3.25.2)

</details>

<details>
<summary>facebook/react (react)</summary>

###
[`v18.3.1`](https://togithub.com/facebook/react/compare/a87edf62d7d69705ddbcec9a24f0780b3db7535f...a87edf62d7d69705ddbcec9a24f0780b3db7535f)

[Compare
Source](https://togithub.com/facebook/react/compare/v18.3.0...v18.3.1)

###
[`v18.3.0`](https://togithub.com/facebook/react/compare/v18.2.0...a87edf62d7d69705ddbcec9a24f0780b3db7535f)

[Compare
Source](https://togithub.com/facebook/react/compare/v18.2.0...v18.3.0)

</details>

<details>
<summary>facebook/react (react-dom)</summary>

###
[`v18.3.1`](https://togithub.com/facebook/react/compare/a87edf62d7d69705ddbcec9a24f0780b3db7535f...a87edf62d7d69705ddbcec9a24f0780b3db7535f)

[Compare
Source](https://togithub.com/facebook/react/compare/v18.3.0...v18.3.1)

###
[`v18.3.0`](https://togithub.com/facebook/react/compare/v18.2.0...a87edf62d7d69705ddbcec9a24f0780b3db7535f)

[Compare
Source](https://togithub.com/facebook/react/compare/v18.2.0...v18.3.0)

</details>

<details>
<summary>vitest-dev/vitest (vitest)</summary>

###
[`v1.5.2`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.1...v1.5.2)

#####    🐞 Bug Fixes

- Check for null before storing in weakmap  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va)
[<samp>(ce368)</samp>](https://togithub.com/vitest-dev/vitest/commit/ce368457)

#####     [View changes on
GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.1...v1.5.2)

###
[`v1.5.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.1)

[Compare
Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.0...v1.5.1)

#####    🚀 Features

- **api**: `startVitest()` to accept `stdout` and `stdin`  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[https://github.com/vitest-dev/vitest/issues/5493](https://togithub.com/vitest-dev/vitest/issues/5493)
[<samp>(780b1)</samp>](https://togithub.com/vitest-dev/vitest/commit/780b187f)
- This is listed as a feature, but it doesn't increase the minor version
because `startVitest` API is experimental and doesn't follow semver.

#####    🐞 Bug Fixes

- Close vite servers on all resolved projects  -  by
[@&#8203;surc54](https://togithub.com/surc54) in
[https://github.com/vitest-dev/vitest/issues/5544](https://togithub.com/vitest-dev/vitest/issues/5544)
[<samp>(413ec)</samp>](https://togithub.com/vitest-dev/vitest/commit/413ec5e6)
- Fix default `import.meta.env.PROD: false`  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5561](https://togithub.com/vitest-dev/vitest/issues/5561)
[<samp>(9c649)</samp>](https://togithub.com/vitest-dev/vitest/commit/9c64967f)
- Resolve cwd correctly when initiating projects  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5582](https://togithub.com/vitest-dev/vitest/issues/5582)
[<samp>(ec9d7)</samp>](https://togithub.com/vitest-dev/vitest/commit/ec9d7c93)
- Always run `onTestFinished` in reverse order  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5598](https://togithub.com/vitest-dev/vitest/issues/5598)
[<samp>(23f29)</samp>](https://togithub.com/vitest-dev/vitest/commit/23f29cea)
-   **browser**:
- Disable `fileParallelism` by default on browser pool  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5528](https://togithub.com/vitest-dev/vitest/issues/5528)
[<samp>(5c69f)</samp>](https://togithub.com/vitest-dev/vitest/commit/5c69f3f5)
- Dispose tester iframe on done  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5595](https://togithub.com/vitest-dev/vitest/issues/5595)
[<samp>(b2135)</samp>](https://togithub.com/vitest-dev/vitest/commit/b2135710)
-   **coverage**:
- Fix bundling of `v8-to-istanbul`  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[https://github.com/vitest-dev/vitest/issues/5549](https://togithub.com/vitest-dev/vitest/issues/5549)
[<samp>(df6a4)</samp>](https://togithub.com/vitest-dev/vitest/commit/df6a4328)
- Prevent crash when `cleanOnRerun` is disabled  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[https://github.com/vitest-dev/vitest/issues/5540](https://togithub.com/vitest-dev/vitest/issues/5540)
[<samp>(ea3c1)</samp>](https://togithub.com/vitest-dev/vitest/commit/ea3c16e4)
- `thresholds` to compare files relative to root  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[https://github.com/vitest-dev/vitest/issues/5574](https://togithub.com/vitest-dev/vitest/issues/5574)
[<samp>(80265)</samp>](https://togithub.com/vitest-dev/vitest/commit/80265b40)
-   **expect**:
- Fix `toEqual` and `toMatchObject` with circular references  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5535](https://togithub.com/vitest-dev/vitest/issues/5535)
[<samp>(9e641)</samp>](https://togithub.com/vitest-dev/vitest/commit/9e6417c9)
-   **vitest**:
- Fix false positive file filter match with leading slash  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[https://github.com/vitest-dev/vitest/issues/5578](https://togithub.com/vitest-dev/vitest/issues/5578)
[<samp>(316eb)</samp>](https://togithub.com/vitest-dev/vitest/commit/316eb739)
- Watch the output directory correctly  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5584](https://togithub.com/vitest-dev/vitest/issues/5584)
[<samp>(e40f9)</samp>](https://togithub.com/vitest-dev/vitest/commit/e40f9924)
- StubEnv casts boolean on PROD/SSR/DEV  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5590](https://togithub.com/vitest-dev/vitest/issues/5590)
[<samp>(4da88)</samp>](https://togithub.com/vitest-dev/vitest/commit/4da88045)

#####     [View changes on
GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.0...v1.5.1)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/brave/ads-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions github-actions bot changed the title Production Release 2024-05-01 Production Release 2024-05-02 May 2, 2024
@tackley tackley marked this pull request as ready for review May 2, 2024 08:23
@tackley tackley requested review from IanKrieger and a team as code owners May 2, 2024 08:23
IanKrieger
IanKrieger previously approved these changes May 2, 2024
View reviewed changes
@tackley tackley requested a review from IanKrieger May 2, 2024 13:55
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

[puLL-Merge] - brave/ads-ui@1180

Here is my review of the PR:

Description

This PR adds a new search campaign creation flow, allowing advertisers to select and customize search ads for a given domain and country. The flow consists of selecting landing pages/creatives, finalizing campaign details, and generating a JSON file with the configuration to submit to Brave.

Changes

Changes

  • src/components/Creatives/SearchPreview.tsx: Adds a new component to preview how a search ad will render
  • src/components/FullScreenProgress.tsx: Adds a new full screen loading spinner component
  • src/graphql-client/gql.ts, src/graphql-client/graphql.ts: Updates GraphQL schema with new search prospect related types and queries
  • src/user/User.tsx: Adds route for new search campaign creation page
  • src/user/hooks/useQueryStringParams.ts: Adds a hook to parse query string parameters
  • src/user/views/user/search/*: Adds multiple new components and pages for the search campaign creation flow
  • src/util/download.ts: Adds utility function to trigger a file download in the browser

Security Hotspots

  1. Allowing arbitrary query string parameters to be added to landing page URLs could potentially be abused if not properly validated and sanitized. The SearchOptionsSchema should have strict validation.
  2. The generated JSON file contains the full landing page URLs which may contain sensitive data. Ensure only authorized users can access the Create Search Campaign page and that the generated file is securely handled.
  3. GraphQL queries for search prospects data should be secured with proper authentication and authorization checks to prevent data leaks.
  4. When rendering the search ad previews, any HTML should be sanitized to prevent XSS vulnerabilities from malformed title/body content.

Let me know if you have any other questions! Overall the code looks well structured and follows existing patterns in the codebase. The main areas to double check are around validation, access control and data security for the new search prospects functionality.

@tackley tackley added this pull request to the merge queue May 2, 2024
Merged via the queue into prod with commit 44e7ed9 May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanKrieger IanKrieger IanKrieger approved these changes

Assignees
No one assigned
Labels
puLL-Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tackley @IanKrieger