Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Remove all referrer exceptions #10825

Closed
pes10k opened this issue Jul 21, 2020 · 1 comment · Fixed by brave/brave-core#6133
Closed

[Desktop] Remove all referrer exceptions #10825

pes10k opened this issue Jul 21, 2020 · 1 comment · Fixed by brave/brave-core#6133
Assignees
@pes10k
Labels
OS/Desktop QA/No release-notes/include
Milestone
1.13.x - Release #1

Comments

@pes10k
Copy link
Contributor

pes10k commented Jul 21, 2020

Now that we have a much better default referrer policy, we should remove the referrer exception system (and remove it from the update service once this hits stable)
@pes10k pes10k added this to the 1.13.x - Nightly milestone Jul 21, 2020
@pes10k pes10k self-assigned this Jul 21, 2020
pes10k added a commit to brave/brave-core that referenced this issue Jul 21, 2020
@pes10k
remove all use and references to the referrer exception service, fixes …
f6ba312 
…brave/brave-browser#10825
@pes10k pes10k mentioned this issue Jul 21, 2020
Merged
32 tasks
pes10k added a commit to brave/brave-core that referenced this issue Jul 21, 2020
@pes10k
remove all use and references to the referrer exception service, fixes …
3a6101a 
…brave/brave-browser#10825
@pes10k
Copy link
Contributor Author

pes10k commented Jul 21, 2020

Tested on as many of the issues as i could pull out of git blame for the exception whitelist repo. In all these cases, things work correctly w/o this list.

https://github.com/brave/brave-browser/issues/7505
https://github.com/brave/brave-browser/issues/2840
https://github.com/brave/brave-browser/issues/9396
https://github.com/brave/brave-browser/issues/6897
https://github.com/brave/brave-browser/issues/7819
https://github.com/brave/brave-browser/issues/9279

https://sdbullion.com/gold-price
https://codepen.io/freq32/pen/pXaOZb
https://store.playstation.com/
https://source.chromium.org/
https://www.obdach.wien/p/obdachlos-tageszentren-josi

pes10k added a commit to brave/brave-core that referenced this issue Jul 22, 2020
@pes10k
remove all use and references to the referrer exception service, fixes …
2d61b75 
…brave/brave-browser#10825
pes10k added a commit to brave/brave-core that referenced this issue Jul 22, 2020
@pes10k
remove all use and references to the referrer exception service, fixes …
51bbddb 
…brave/brave-browser#10825
pes10k added a commit to brave/brave-core that referenced this issue Jul 22, 2020
@pes10k
remove all use and references to the referrer exception service, fixes …
7ba94d7 
…brave/brave-browser#10825
@LaurenWags LaurenWags mentioned this issue Aug 26, 2020
Closed
@pes10k pes10k mentioned this issue Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pes10k pes10k

Labels
OS/Desktop QA/No release-notes/include
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

remove all use of and references to the referrer exception service brave/brave-core
1 participant
@pes10k