Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 89.0.4389.48 to Chromium 89.0.4389.58. #14227

Closed
mkarolin opened this issue Feb 17, 2021 · 2 comments · Fixed by brave/brave-core#7988 or #14230
Closed

Upgrade from Chromium 89.0.4389.48 to Chromium 89.0.4389.58. #14227

mkarolin opened this issue Feb 17, 2021 · 2 comments · Fixed by brave/brave-core#7988 or #14230

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Feb 17, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/89.0.4389.48..89.0.4389.58?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

  • Brower binary size on linux (should not be significantly larger than in prior builds).
  • Bookmarks context menu.
@LaurenWags
Copy link
Member

labelling as QA/Blocked for now, a new build is required.

@srirambv
Copy link
Contributor

srirambv commented Feb 25, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.68 x64 build

  • Verified bookmarks menu works as expected

Verification passed on OnePlus 6T with Android 10 running 1.21.68 x64 build

  • Verified bookmarks menu works as expected
OnePlus 6T Samsung Tab A

Verification passed on


Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)


  • Verified bookmarks context menu works as expected

image


Verification passed on

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Ubuntu 18.04 LTS
  • Verified bookmarks context menu works as expected
    image
  • Browser binary size on linux is only 1.7MB bigger than in 1.20.110
    image

Verified passed with

Brave | 1.21.69 Chromium: 89.0.4389.69 (Official Build) (x86_64)
-- | --
Revision | 6df9174a477a0bea2118cb4669954d517be16104-refs/branch-heads/4389@{#1332}
OS | macOS Version 10.15.7 (Build 19H512)

version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment