Fix Include in Auto-Contribute toggle #8295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14413
Internally, we store the publisher exclusion state as an integer-based enumeration. However, some of our publisher-related extension API functions send this value as a
boolean
while others send it as anumber
. This was causing confusion in the UI as any non-zero number was causing the state to be interpreted as excluded.Since we only use this state as a Boolean in the UI (i.e., nothing in the UI cares about anything other than two states: exclude or include), I standardized on always sending it to the UI as a Boolean.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
I'd repeat these steps a few times and also try with a clean profile. There are also useful STR in brave/brave-browser#14413 that we should also check.