Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Include in Auto-Contribute toggle #8295

Merged
merged 1 commit into from Mar 19, 2021
Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Mar 18, 2021

Resolves brave/brave-browser#14413

Internally, we store the publisher exclusion state as an integer-based enumeration. However, some of our publisher-related extension API functions send this value as a boolean while others send it as a number. This was causing confusion in the UI as any non-zero number was causing the state to be interpreted as excluded.

Since we only use this state as a Boolean in the UI (i.e., nothing in the UI cares about anything other than two states: exclude or include), I standardized on always sending it to the UI as a Boolean.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Visit https://twitter.com/bravelaurenwags
  • Open Rewards panel a few times and verify that toggle state of "Include in Auto-Contribution" doesn't change
  • Toggle the state of the button
  • Open Rewards panel a few times and verify that toggle state of "Include in Auto-Contribution" doesn't change

I'd repeat these steps a few times and also try with a clean profile. There are also useful STR in brave/brave-browser#14413 that we should also check.

@emerick emerick requested a review from zenparsing March 18, 2021 19:51
@emerick emerick self-assigned this Mar 18, 2021
Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - eventually we'll get rid of all of these C++ enum values leaking into JS!

@emerick
Copy link
Contributor Author

emerick commented Mar 19, 2021

Android, Linux, Windows passed CI; restarting for Mac and iOS.

@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Mar 19, 2021
@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-linux labels Mar 19, 2021
@emerick
Copy link
Contributor Author

emerick commented Mar 19, 2021

CI passed on iOS and MacOS, ready to merge.

@emerick emerick merged commit c1445c4 into master Mar 19, 2021
@emerick emerick deleted the fix-include-in-ac-toggle branch March 19, 2021 08:59
@emerick emerick added this to the 1.24.x - Nightly milestone Mar 19, 2021
tmancey pushed a commit that referenced this pull request Mar 19, 2021
Fix Include in Auto-Contribute toggle
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants