Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site permission link is not redirecting to the expected page in the Guest window #15180

Open
GeetaSarvadnya opened this issue Apr 7, 2021 · 1 comment
Labels
bug OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/feature User-facing privacy- & security-focused feature work. privacy/permissions privacy features related to limiting, lifetime or other permissions QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 7, 2021

Description

Found while testing #14127

The site permission link is not redirecting to the expected page in the Guest window, click on the Site permission link is redirecting to brave://settings/ instead of brave://settings/content. Even If we Block the permission there is no any brave://settings/content settings to check whether the location permission is blocked or not in the Guest window. Not sure this behavior is required in the Guest window or not.

image

Steps to Reproduce

  1. Clean profile 1.23.x
  2. Open chrome://flags and enable the Permission lifetime flag
  3. Open browserleaks.com/geo in the guest window
  4. Click on Site permission link

Actual result:

click on the Site permission link is redirecting to brave://settings/ instead of brave://settings/content
Site permission_Guest winow

Expected result

The link should redirect to the correct page like normal windows. Not sure Site permission link is required in the Guest window, If not this needs to removed from the Guest window

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.23.65 Chromium: 89.0.4389.114 (Official Build) dev (64-bit)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS Windows 10 OS Version 2004 (Build 19041.867)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

I am not sure what is the expected behavior for the Guest window cc: @karenkliu

cc: @brave/legacy_qa @rebron @karenkliu

@GeetaSarvadnya GeetaSarvadnya added privacy/feature User-facing privacy- & security-focused feature work. QA/Yes QA/Test-Plan-Specified OS/Desktop privacy/permissions privacy features related to limiting, lifetime or other permissions bug labels Apr 7, 2021
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 13, 2021
@rebron
Copy link
Collaborator

rebron commented Apr 13, 2021

@goodov If we can, we'd like the link hidden for guest window since there are no settings stored for this while using guest profile/window.

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P4 Backlog in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/feature User-facing privacy- & security-focused feature work. privacy/permissions privacy features related to limiting, lifetime or other permissions QA/Test-Plan-Specified QA/Yes
Projects
Status: P4 Backlog
Development

No branches or pull requests

2 participants