Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"chrome://" still being displayed when editing URL bar #1616

Closed
kjozwiak opened this issue Oct 16, 2018 · 6 comments · Fixed by brave/brave-core#1385
Closed

"chrome://" still being displayed when editing URL bar #1616

kjozwiak opened this issue Oct 16, 2018 · 6 comments · Fixed by brave/brave-core#1385
Labels
feature/url-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.62.x - Release ...

Comments

@kjozwiak
Copy link
Member

Description

When editing the URL bar, you'll still be able to see the chrome:// protocol handler rather than the brave://

Steps to Reproduce

  1. open either dev or beta
  2. visit brave://settings and start editing the URL once the page loads

Actual result:

urlprotocal

Expected result:

Shouldn't be displaying the chrome:// protocol handler when editing the URL box.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes, currently reproducible on both dev and beta builds:

Brave 0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
Brave 0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
@kjozwiak kjozwiak added this to the 1.x Backlog milestone Oct 16, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 19, 2018
@srirambv
Copy link
Contributor

+1 from https://community.brave.com/t/chrome-reference-in-brave-settings/35882

@srirambv srirambv mentioned this issue Nov 2, 2018
Closed
@srirambv
Copy link
Contributor

srirambv commented Nov 2, 2018

+1 from @kirkins via #1973 for copy paste brave://

@rebron rebron added this to Prioritized Backlog in Front End Nov 6, 2018
@fmarier fmarier mentioned this issue Dec 12, 2018
Closed
18 tasks
@fmarier
Copy link
Member

fmarier commented Dec 12, 2018

This will be fixed by brave/brave-core#1074.

fmarier added a commit to fmarier/brave-core that referenced this issue Dec 12, 2018
@fmarier
Hide the chrome-extension prefix in PDFjs URLs (closes brave/brave-br…
7789df8 
…owser#368)

Both GetFormattedFullURL() and GetURLForDisplay() need to be overridden in
order for the URL to be displayed properly in the URL bar and to be copy/pasted
properly when editing the URL.

This also fixes brave/brave-browser#1616.
@srirambv srirambv mentioned this issue Dec 14, 2018
Closed
fmarier added a commit to fmarier/brave-core that referenced this issue Jan 16, 2019
@fmarier
Rewrite chrome:// in edit URLs too (closes brave/brave-browser#1616)
af1eb21 
Both GetFormattedFullURL() and GetURLForDisplay() need to be overridden in
order for the URL to be displayed properly in the URL bar and to be copy/pasted
properly when editing the URL.
@fmarier fmarier self-assigned this Jan 16, 2019
@fmarier fmarier mentioned this issue Jan 16, 2019
Closed
18 tasks
bridiver added a commit to brave/brave-core that referenced this issue Jan 18, 2019
@bridiver
use brave:// for the virtual url and chrome:// for the internal u…
d43dd5f 
…rl to load

fix brave/brave-browser#1616
@bridiver bridiver mentioned this issue Jan 18, 2019
Merged
18 tasks
bridiver added a commit to brave/brave-core that referenced this issue Jan 22, 2019
@bridiver
use brave:// for the virtual url and chrome:// for the internal u…
315a62c 
…rl to load

fix brave/brave-browser#1616
bridiver added a commit to brave/brave-core that referenced this issue Jan 22, 2019
@bridiver
use brave:// for the virtual url and chrome:// for the internal u…
40f6eba 
…rl to load

fix brave/brave-browser#1616
bridiver added a commit to brave/brave-core that referenced this issue Jan 22, 2019
@bridiver
use brave:// for the virtual url and chrome:// for the internal u…
742129b 
…rl to load

fix brave/brave-browser#1616
@srirambv srirambv mentioned this issue Jan 31, 2019
Closed
@srirambv
Copy link
Contributor

+1 from @anushshetty8 via #3170

@bbondy bbondy modified the milestones: 1.x Backlog, 0.62.x - Nightly Feb 6, 2019
@rebron rebron moved this from P1 & P2 backlog to Completed in Front End Feb 12, 2019
@btlechowski
Copy link

btlechowski commented Mar 1, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.62.11 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used STR from the description.
Checked all URL from: brave://chrome-urls/

Verification passed on

Brave 0.62.26 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
  • Verified the STR from the description
  • Tried editing the chrome-urls in Normal tab/Guest window/Private window/Tor window - Chrome handler is not shown in any case.

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.62.27 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

@srirambv srirambv mentioned this issue Mar 13, 2019
Closed
This was referenced Apr 2, 2021
Open
Closed
@manikandancode manikandancode mentioned this issue Apr 4, 2021
Closed
@LaurenWags LaurenWags mentioned this issue Apr 6, 2021
Closed
This was referenced Apr 7, 2021
Closed
Closed
@BananaOnGitHub BananaOnGitHub mentioned this issue Apr 7, 2021
Open
This was referenced Apr 7, 2021
Closed
Closed
@dev dev mentioned this issue Apr 7, 2021
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 7, 2021
Open
This was referenced Apr 7, 2021
Closed
Closed
Closed
@akshaybhalotia akshaybhalotia mentioned this issue Apr 8, 2021
Closed
@btlechowski btlechowski mentioned this issue Apr 8, 2021
Closed
@heyJonBray heyJonBray mentioned this issue Apr 8, 2021
Closed
@bilaalukis bilaalukis mentioned this issue Apr 9, 2021
Closed
@Tonev Tonev mentioned this issue Apr 9, 2021
Open
@brawaru brawaru mentioned this issue Apr 9, 2021
Closed
@MitchEspr MitchEspr mentioned this issue Apr 9, 2021
Closed
@hillbilly128 hillbilly128 mentioned this issue Apr 11, 2021
Closed
This was referenced Apr 12, 2021
Closed
Closed
Closed
@xstable xstable mentioned this issue Apr 12, 2021
Open
@Legendhidde Legendhidde mentioned this issue Apr 14, 2021
Closed
@Legend-of-iPhoenix Legend-of-iPhoenix mentioned this issue Apr 14, 2021
Open
@rahulsnkr rahulsnkr mentioned this issue Apr 18, 2021
Closed
@UbioZur UbioZur mentioned this issue Nov 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/url-bar priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

use brave:// for the virtual url and chrome:// for the internal u… brave/brave-core
8 participants
@fmarier @bbondy @kjozwiak @bsclifton @rebron @srirambv @btlechowski @GeetaSarvadnya