Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.PNG .JPG and .GIF files cannot be viewed via IPFS import #16758

Closed
GeetaSarvadnya opened this issue Jul 2, 2021 · 8 comments
Closed

.PNG .JPG and .GIF files cannot be viewed via IPFS import #16758

GeetaSarvadnya opened this issue Jul 2, 2021 · 8 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 2, 2021

Description

Found while testing #16267
.PNG .JPG and .GIF files cannot be viewed via IPFS import

Steps to Reproduce

  1. Clean profile 1.27.x
  2. Launch brave using --use-dev-goupdater-url
  3. Make sure IPFS version is 0.9.0 in brave://ipfs-internals
  4. Import .PNG .JPG and .GIF files from the local machine
  5. Import is successful but files can't be viewed

Actual result:

.PNG and .JPG files cannot be viewed via IPFS import
image

image

Expected result:

Should be able to view .PNG and .JPG files via IPFS import

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.27.87 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2004 (Build 19041.1052)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @spylogsster @brave/legacy_qa @rebron

@GeetaSarvadnya GeetaSarvadnya changed the title .PNG and .JPG files cannot be viewed via IPFS import .PNG .JPG and .GIF files cannot be viewed via IPFS import Jul 2, 2021
@stephendonner
Copy link

@GeetaSarvadnya if you turn off Shields, does it render?

I had a similar issue on Linux, also 1.27.87:

Shields up Shields down
Screen Shot 2021-07-02 at 2 06 48 PM Screen Shot 2021-07-02 at 2 07 45 PM

/cc @spylogsster

@lidel
Copy link

lidel commented Jul 2, 2021

This seems to be a variant of #13641 however here we are on a trusted API port (45004) that tries to fetch the image from the trusted Gateway port (45083).

This is a pretty safe environment, as both Origins are controlled by Brave (brave runs go-ipfs binary, which exposes those ports)

I think the right way of fixing this class of bugs is to allow API port to fetch data from local Gateway.

@GeetaSarvadnya
Copy link
Author

@stephendonner with Shields ON/OFF I am getting the same issue.

IPFS_Shileds ON or OFF

@lidel
Copy link

lidel commented Jul 6, 2021

This is the same issue as #16752 (comment)
(Due to fallback the preview image is being fetched from ipfs.io instead of local gateway.)

The fix here is to wait until we have go-ipfs 0.9.1 with bugfix release of webui: ipfs/kubo#8243

@spylogsster
Copy link

blocked by ipfs/kubo#8243

@stephendonner
Copy link

stephendonner commented Aug 11, 2021

@GeetaSarvadnya mind retesting with go-ipfs version 0.9.1 now that it's out using --use-dev-goupdater-url?

This worked for me using

Brave 1.30.15 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.2 (Build 20G95)

Screen Shot 2021-08-11 at 3 24 37 PM


Verified on Linux as well. Imported images for PNG/JPG/JPEG/GIF all show and can be loaded as well
image

@stephendonner stephendonner added this to the IPFS node release 0.9.1 milestone Aug 18, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.28.105 Chromium: 92.0.4515.131 (Official Build) (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.2 (Build 20G95)

and go-ipfs 0.9.1

example example example example
Screen Shot 2021-08-18 at 1 07 02 PM Screen Shot 2021-08-18 at 1 08 01 PM Screen Shot 2021-08-18 at 1 08 39 PM Screen Shot 2021-08-18 at 1 08 51 PM

@GeetaSarvadnya
Copy link
Author

@stephendonner Apologies somehow missed the issue. Today I have verified the issue on Windows 10 x64 - 1.28.106 build issue is fixed and working fine with ipfs component 0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants