Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make not supported messages more specific #19815

Closed
bbondy opened this issue Nov 29, 2021 · 2 comments · Fixed by brave/brave-core#11848
Closed

Make not supported messages more specific #19815

bbondy opened this issue Nov 29, 2021 · 2 comments · Fixed by brave/brave-core#11848
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 29, 2021

Some users are confused that we don't support EVM compatible chains because the buttons are disabled and the tooltip is not specific enough.

https://community.brave.com/t/how-can-i-connect-bsc-on-new-brave-wallet/302966/15
Screen Shot 2021-11-29 at 3 49 02 PM

We should instead say Buy support is not available for Avalanche.
and Swap support is not available for Avalanche.
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 29, 2021
@muliswilliam muliswilliam self-assigned this Jan 10, 2022
@muliswilliam muliswilliam mentioned this issue Jan 14, 2022
Merged
25 tasks
@muliswilliam muliswilliam added this to the 1.36.x - Nightly milestone Jan 14, 2022
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Mar 2, 2022

Brave 1.36.108 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11848
  • Verified both Buy & Swap on widget and panel shows not supported message with the network name
  • Encountered #21402
Buy Widget
Swap Widget
Buy on Panel
Swap on Panel

@srirambv
Copy link
Contributor

srirambv commented Mar 2, 2022

Removing Android label as there is no Buy/Swap options shown for unsupported network which was fixed as part of brave/brave-core#12204

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Make not supported messages more specific brave/brave-core
3 participants
@bbondy @srirambv @muliswilliam