Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Verify Sorted Box Bigger for 24 Word Recovery Phrases #20125

Closed
Douglashdaniel opened this issue Dec 16, 2021 · 1 comment · Fixed by brave/brave-core#11630
Closed

Make Verify Sorted Box Bigger for 24 Word Recovery Phrases #20125

Douglashdaniel opened this issue Dec 16, 2021 · 1 comment · Fixed by brave/brave-core#11630
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Dec 16, 2021 •
edited
Loading

Description

  1. Make the Verify Sorted Box Bigger if Recovery Phrase is 24 words
  2. Change the text in the first backup step to say 24 if Recovery Phrase is 24 words

Screen Shot 2021-12-15 at 5 49 41 PM

Screen Shot 2021-12-15 at 5 58 09 PM
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 16, 2021
@Douglashdaniel Douglashdaniel self-assigned this Dec 16, 2021
@muliswilliam muliswilliam mentioned this issue Dec 17, 2021
Merged
25 tasks
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 21, 2021
@srirambv
Copy link
Contributor

Brave 1.35.89 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11630
  • Verified welcome message is updated based on the number of seed words in the wallet
  • Verified input box for seed words is adjusted based on the input seed words(12/15/24)
24-word Welcome message
24-word Seed phrase Backup
12-word Welcome Message
12-word Seed Phrase Backup

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Make verify sorted box bigger for different lengths of recovery phrase brave/brave-core
3 participants
@srirambv @Douglashdaniel @muliswilliam