Attempting to delete brave shields generated cookie settings can sometimes create unrecoverable inconsistencies between the shield setting and the actual cookie setting

[bridiver]

Description

Attempting to delete brave shields generated cookie settings can sometimes create unrecoverable inconsistencies between the shield setting and the actual cookie setting

Steps to Reproduce

1. go to brave.com
2. toggle shields cookie settings to block all and back to block cross-site again
3. disable shields for brave.com
4. go to brave://settings/cookies and click the trash can icon for the rule allowing embedded cookies on brave.com
5. enable shields for brave.com

Actual result:

Shields says cross site cookies are block, but brave://settings/cookies says all cookies are allowed and that is likely the actual setting as well

Expected result:

Cross site cookies should still be blocked

Reproduces how often:

Always

Brave version (info found on brave://version)

1.36.39

Version/Channel Information:

all channels

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the dev channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? no
• Does the issue resolve itself when disabling Brave Rewards? no
• Is the issue reproducible on the latest version of Chrome? NA

[bridiver]

I left this as no QA because this functionality was already broken, this just prevents it from causing more problems for people until we have a real fix