Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the dropdown label string 'State level ad targeting' in brave://rewards ads settings #21291

Closed
jenn-rhim opened this issue Feb 24, 2022 · 9 comments · Fixed by brave/brave-core#12553
Assignees
Labels
enhancement feature/ads needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude

Comments

@jenn-rhim
Copy link

jenn-rhim commented Feb 24, 2022

Replace the term 'targeting' in our labels to avoid association with the non-private ad targeting
@tmancey @jsecretan @rmcfadden3

@tmancey tmancey added feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. enhancement needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Feb 24, 2022
@tmancey tmancey changed the title Change the dropdown label string 'State level ad targeting' in BR settings Change the dropdown label string 'State level ad targeting' in brave://rewards ads settings Feb 28, 2022
@rmcfadden3
Copy link

Seems like a good idea to me.

How about replacing with the concept of "relevancy" instead? So "State-level ad relevance"

@tmancey
Copy link
Contributor

tmancey commented Feb 28, 2022

In the not too distant future we will also have provinces for Canada so from a development point of view we need to make sure translators are aware, i.e. Province-level ad relevance for Canada. County-level ad relevance for the UK etc.

@rmcfadden3
Copy link

@tmancey — good callout. In that case, could generalize to "Location-level ad relevance"

@tmancey
Copy link
Contributor

tmancey commented Feb 28, 2022

@rmcfadden3 https://en.wikipedia.org/wiki/ISO_3166-2 is the iso standard for identifying the principal subdivisions. i.e. provinces, states, parishes etc.

@tmancey
Copy link
Contributor

tmancey commented Mar 9, 2022

@rmcfadden3 what do you think of "Regional ad relevance" for the title and "This allows Brave to show you ads meant specifically for your region." for the description

@rmcfadden3
Copy link

@tmancey — I'm good with that.

@stephendonner
Copy link

stephendonner commented Mar 30, 2022

Verified PASSED using

Brave 1.38.74 Chromium: 100.0.4896.60 (Official Build) beta (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)
JavaScript V8 10.0.139.8
brave://rewards (fixed) brave://settings/rewards (old)
Screen Shot 2022-03-30 at 3 26 03 PM Screen Shot 2022-03-30 at 3 25 58 PM

NOTE: filed #22001 to cover the missed brave://settings/rewards page 👍


Verification PASSED on

Brave | 1.38.75 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
-- | --
Revision | 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Brave://rewards brave://settings/rewards
image image

@btlechowski
Copy link

Verification passed on

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS

image

@stephendonner
Copy link

Verified PASSED using Brave 1.38.88, Chromium 100.0.4896.79 on a Google Pixel XL (arm64) running Android 9.0.

Screenshot_20220411-230750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/ads needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Archived in project
6 participants