Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message to mention why adding an asset fails #21296

Closed
srirambv opened this issue Feb 24, 2022 · 3 comments · Fixed by brave/brave-core#16761
Closed

Update error message to mention why adding an asset fails #21296

srirambv opened this issue Feb 24, 2022 · 3 comments · Fixed by brave/brave-core#16761
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop OS/iOS Fixes related to iOS browser functionality polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Currently when you try to add a custom asset that is already added/listed as visible asset it throws an error that says Failed to add custom token, please try again but doesn't tell why its failed. We should add details so its clear as to why it can't be added.

cc: @jamesmudgett @nuo-xu @SergeyZhukovsky @Douglashdaniel

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Feb 24, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 25, 2022
@josheleonard josheleonard self-assigned this Mar 1, 2022
@josheleonard josheleonard removed their assignment Mar 1, 2022
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 16, 2022
@bbondy bbondy added this to Web3 Mar 16, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 16, 2022
@HEagle18
Copy link

@Douglashdaniel would you be able to take this ?

I just redid the flow.

  • Added OKB as a custom token
  • it was successful
  • tried to readd it by entering contract address
  • it just skips to next main screen
  • if you return, you get 'failed to add custom token'

Could we add 'token already added to portfolio'

@srirambv
Copy link
Contributor Author

Android specific issue #28670 is logged, removing OS/Android label

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#16761
  • Verified trying to add an existing token shows the error message and disabled Add button
21296.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16761
  • Verified trying to add an existing token shows the error message and disabled Add button
21296.mp4

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16761
  • Verified trying to add an existing token shows the error message and disabled Add button
21296.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop OS/iOS Fixes related to iOS browser functionality polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants